MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder

MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder

Because there isn't such a functionality on ToT.
Also added unittest for Audio Pause()/Resume().

BUG=593560
Committed: https://crrev.com/c7c11ecc88a64e88896afe8e66ff69512714d162
Cr-Commit-Position: refs/heads/master@{#382668}

[mcasas, 2016-03-22 14:08:32]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-03-22 14:08:41]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-03-22 14:08:48]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-03-22 14:08:55]

Patchset #1 (id:60001) has been deleted

[mcasas, 2016-03-22 15:18:37]

Description was changed from

==========
MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder

Also added unittest for Audio Pause()/Resume().

BUG=593560
==========

to

==========
MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder

Because there isn't such a functionality on ToT. 
Also added unittest for Audio Pause()/Resume().

BUG=593560
==========

[mcasas, 2016-03-22 15:21:52]

Patchset #1 (id:80001) has been deleted

[mcasas, 2016-03-22 15:22:02]

mcasas@chromium.org changed reviewers:
+ emircan@chromium.org

[mcasas, 2016-03-22 15:22:02]

emircan@ PTAL

[mcasas, 2016-03-22 17:56:57]

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
File content/renderer/media/audio_track_recorder.cc (right):

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
content/renderer/media/audio_track_recorder.cc:345:
DCHECK(capture_thread_checker_.CalledOnValidThread());
s/capture_thread_checker_/main_render_thread_checker_/
here and in l.352.

[emircan, 2016-03-22 18:09:30]

lgtm % nits.

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
File content/renderer/media/audio_track_recorder.cc (right):

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
content/renderer/media/audio_track_recorder.cc:345:
DCHECK(capture_thread_checker_.CalledOnValidThread());
On 2016/03/22 17:56:57, mcasas wrote:
> s/capture_thread_checker_/main_render_thread_checker_/
> here and in l.352.

Also revert the comment on l.286.

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
File content/renderer/media/audio_track_recorder_unittest.cc (right):

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
content/renderer/media/audio_track_recorder_unittest.cc:273:
INSTANTIATE_TEST_CASE_P(, AudioTrackRecorderTest, ValuesIn(kATRTestParams));
Move this after l.302.

[mcasas, 2016-03-22 20:21:02]

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
File content/renderer/media/audio_track_recorder.cc (right):

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
content/renderer/media/audio_track_recorder.cc:345:
DCHECK(capture_thread_checker_.CalledOnValidThread());
On 2016/03/22 18:09:30, emircan wrote:
> On 2016/03/22 17:56:57, mcasas wrote:
> > s/capture_thread_checker_/main_render_thread_checker_/
> > here and in l.352.
> 
> Also revert the comment on l.286.

Discussed offline, the comment is correct now.

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
File content/renderer/media/audio_track_recorder_unittest.cc (right):

https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media...
content/renderer/media/audio_track_recorder_unittest.cc:273:
INSTANTIATE_TEST_CASE_P(, AudioTrackRecorderTest, ValuesIn(kATRTestParams));
On 2016/03/22 18:09:30, emircan wrote:
> Move this after l.302.

Done.

[mcasas, 2016-03-22 20:32:36]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-03-22 20:32:36]

The patchset sent to the CQ was uploaded after l-g-t-m from emircan@chromium.org
Link to the patchset: https://codereview.chromium.org/1819103004/#ps120001
(title: "comments")

[commit-bot: I haz the power, 2016-03-22 20:32:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819103004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819103004/120001

[commit-bot: I haz the power, 2016-03-22 20:38:13]

Description was changed from

==========
MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder

Because there isn't such a functionality on ToT. 
Also added unittest for Audio Pause()/Resume().

BUG=593560
==========

to

==========
MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder

Because there isn't such a functionality on ToT. 
Also added unittest for Audio Pause()/Resume().

BUG=593560
==========

[commit-bot: I haz the power, 2016-03-22 20:38:14]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-03-22 20:39:49]

Description was changed from

==========
MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder

Because there isn't such a functionality on ToT. 
Also added unittest for Audio Pause()/Resume().

BUG=593560
==========

to

==========
MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder

Because there isn't such a functionality on ToT.
Also added unittest for Audio Pause()/Resume().

BUG=593560

Committed: https://crrev.com/c7c11ecc88a64e88896afe8e66ff69512714d162
Cr-Commit-Position: refs/heads/master@{#382668}
==========

[commit-bot: I haz the power, 2016-03-22 20:39:50]

Patchset 2 (id:??) landed as
https://crrev.com/c7c11ecc88a64e88896afe8e66ff69512714d162
Cr-Commit-Position: refs/heads/master@{#382668}