Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1819103004: MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder (Closed)

Created:
4 years, 9 months ago by mcasas
Modified:
4 years, 9 months ago
Reviewers:
emircan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorder: Add Pause()/Resume() to AudioTrackRecorder Because there isn't such a functionality on ToT. Also added unittest for Audio Pause()/Resume(). BUG=593560 Committed: https://crrev.com/c7c11ecc88a64e88896afe8e66ff69512714d162 Cr-Commit-Position: refs/heads/master@{#382668}

Patch Set 1 : #

Total comments: 5

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -28 lines) Patch
M content/renderer/media/audio_track_recorder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/audio_track_recorder.cc View 1 6 chunks +22 lines, -3 lines 0 comments Download
M content/renderer/media/audio_track_recorder_unittest.cc View 1 4 chunks +43 lines, -25 lines 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
mcasas
emircan@ PTAL
4 years, 9 months ago (2016-03-22 15:22:02 UTC) #8
mcasas
https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media/audio_track_recorder.cc File content/renderer/media/audio_track_recorder.cc (right): https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media/audio_track_recorder.cc#newcode345 content/renderer/media/audio_track_recorder.cc:345: DCHECK(capture_thread_checker_.CalledOnValidThread()); s/capture_thread_checker_/main_render_thread_checker_/ here and in l.352.
4 years, 9 months ago (2016-03-22 17:56:57 UTC) #9
emircan
lgtm % nits. https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media/audio_track_recorder.cc File content/renderer/media/audio_track_recorder.cc (right): https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media/audio_track_recorder.cc#newcode345 content/renderer/media/audio_track_recorder.cc:345: DCHECK(capture_thread_checker_.CalledOnValidThread()); On 2016/03/22 17:56:57, mcasas wrote: ...
4 years, 9 months ago (2016-03-22 18:09:30 UTC) #10
mcasas
https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media/audio_track_recorder.cc File content/renderer/media/audio_track_recorder.cc (right): https://codereview.chromium.org/1819103004/diff/100001/content/renderer/media/audio_track_recorder.cc#newcode345 content/renderer/media/audio_track_recorder.cc:345: DCHECK(capture_thread_checker_.CalledOnValidThread()); On 2016/03/22 18:09:30, emircan wrote: > On 2016/03/22 ...
4 years, 9 months ago (2016-03-22 20:21:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819103004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819103004/120001
4 years, 9 months ago (2016-03-22 20:32:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 9 months ago (2016-03-22 20:38:14 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 20:39:50 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7c11ecc88a64e88896afe8e66ff69512714d162
Cr-Commit-Position: refs/heads/master@{#382668}

Powered by Google App Engine
This is Rietveld 408576698