Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 18191007: MIPS: Hydrogen array constructor cleanup and improvements. (Closed)

Created:
7 years, 5 months ago by kilvadyb
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Hydrogen array constructor cleanup and improvements. Port r15383 (3e90aaf) Original commit message: * Cleanup of LCallNewArray::PrintDataTo() method * Created HCallNewArray::PrintDataTo() * Created many more tests in array-constructor-feedback.js * Removed redundant instructions in GenerateRecordCallTarget * Bugfix in CreateArrayDispatchOneArgument: on a call to new Array(0), we'd like to set the type feedback cell to a packed elements kind, but we shouldn't do it if the cell contains the megamorphic sentinel. * When used from crankshaft, ArrayConstructorStubs can avoid verifying that the function being called is the array function from the current native context, relying instead on the fact that crankshaft issues an HCheckFunction to protect the constructor call. (this new minor key is used in LCodeGen::DoCallNewArray(), and influences code generation in CodeStubGraphBuilderBase::BuildArrayConstructor()). * Optimization: the array constructor specialized for FAST_SMI_ELEMENTS can save some instructions by looking up the correct map on the passed in constructor, rather than indexing into the array of cached maps per element kind. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M src/mips/code-stubs-mips.cc View 3 chunks +13 lines, -5 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 5 months ago (2013-06-28 15:42:01 UTC) #1
kisg
LGTM
7 years, 5 months ago (2013-06-28 17:01:30 UTC) #2
palfia
7 years, 5 months ago (2013-06-28 17:17:14 UTC) #3
Committed as r15395.

Powered by Google App Engine
This is Rietveld 408576698