Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1819093002: Remove base_i18n dependency from //components/metrics:metrics target (Closed)

Created:
4 years, 9 months ago by xunjieli
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base_i18n dependency from //components/metrics:metrics target base_i18n dependency is only used for a DVLOG in daily_event.cc. This CL removes this dependency since base_i18n pulls ICU dependency which is fairly large. BUG=596506 Committed: https://crrev.com/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e Cr-Commit-Position: refs/heads/master@{#382421}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M components/metrics.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/daily_event.cc View 2 chunks +1 line, -3 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
xunjieli
PTAL. Thanks! https://codereview.chromium.org/1819093002/diff/20001/components/metrics/daily_event.cc File components/metrics/daily_event.cc (right): https://codereview.chromium.org/1819093002/diff/20001/components/metrics/daily_event.cc#newcode71 components/metrics/daily_event.cc:71: DVLOG(1) << "DailyEvent time loaded: " << ...
4 years, 9 months ago (2016-03-21 21:02:13 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 9 months ago (2016-03-21 21:41:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819093002/20001
4 years, 9 months ago (2016-03-21 21:53:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-21 22:44:30 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 22:46:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e
Cr-Commit-Position: refs/heads/master@{#382421}

Powered by Google App Engine
This is Rietveld 408576698