Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/WebKit/Source/core/paint/TableCellPainter.h

Issue 1819073004: Fix table cell background painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cr fixes, remove tiling algorithm Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/TableCellPainter.h
diff --git a/third_party/WebKit/Source/core/paint/TableCellPainter.h b/third_party/WebKit/Source/core/paint/TableCellPainter.h
index e195120e90fcc1008955e2c58dbd3bd91fb386a6..d19270d70b1991e1493146e71ce3504ceabba2a8 100644
--- a/third_party/WebKit/Source/core/paint/TableCellPainter.h
+++ b/third_party/WebKit/Source/core/paint/TableCellPainter.h
@@ -13,6 +13,7 @@ namespace blink {
struct PaintInfo;
class CollapsedBorderValue;
+class LayoutBox;
class LayoutPoint;
class LayoutRect;
class LayoutTableCell;
@@ -27,7 +28,7 @@ public:
void paint(const PaintInfo&, const LayoutPoint&);
void paintCollapsedBorders(const PaintInfo&, const LayoutPoint&, const CollapsedBorderValue&);
- void paintBackgroundsBehindCell(const PaintInfo&, const LayoutPoint&, const LayoutObject* backgroundObject, DisplayItem::Type);
+ void paintBackgroundsBehindCell(const PaintInfo&, const LayoutPoint&, const LayoutBox& backgroundObject, DisplayItem::Type);
void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoint& paintOffset);
void paintMask(const PaintInfo&, const LayoutPoint& paintOffset);
@@ -37,6 +38,11 @@ public:
LayoutRect paintBounds(const LayoutPoint& paintOffset, PaintBoundOffsetBehavior);
private:
+ void paintParentBackgroundsBehindCell(const PaintInfo&, const LayoutPoint&, const LayoutBox& backgroundObject, DisplayItem::Type);
+
+ // Computed bounds for parent background objects.
+ LayoutRect paintBoundsParent(const LayoutPoint& paintOffset, const LayoutBox&, DisplayItem::Type);
+
const CollapsedBorderValue* cachedCollapsedLeftBorder(const ComputedStyle&) const;
const CollapsedBorderValue* cachedCollapsedRightBorder(const ComputedStyle&) const;
const CollapsedBorderValue* cachedCollapsedTopBorder(const ComputedStyle&) const;

Powered by Google App Engine
This is Rietveld 408576698