Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1819073003: [es6] Don't disable ES6 tail call elimination when Debugger is on. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Don't disable ES6 tail call elimination when Debugger is on. BUG=v8:4698 LOG=N Committed: https://crrev.com/a7ac81f41a62f3684961ec0c8486c95d39ce038f Cr-Commit-Position: refs/heads/master@{#34986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -85 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/s390/builtins-s390.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819073003/1
4 years, 9 months ago (2016-03-22 11:41:11 UTC) #3
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-22 11:41:24 UTC) #5
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-22 11:48:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 12:15:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819073003/1
4 years, 9 months ago (2016-03-22 12:36:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 12:38:37 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 12:39:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7ac81f41a62f3684961ec0c8486c95d39ce038f
Cr-Commit-Position: refs/heads/master@{#34986}

Powered by Google App Engine
This is Rietveld 408576698