Support for Android Swarming bots

tools/buildbot_spec.py

Index: tools/buildbot_spec.py
diff --git a/tools/buildbot_spec.py b/tools/buildbot_spec.py
index 2582fba3db053eccd6b96df1273b9489da4fec99..79ebc0df5a5d7656e99a1889a3650f336e474212 100755
--- a/tools/buildbot_spec.py
+++ b/tools/buildbot_spec.py
@@ -227,6 +227,7 @@ def device_cfg(builder_dict):
       'Nexus5':        'arm_v7_neon',
       'Nexus6':        'arm_v7_neon',
       'Nexus7':        'arm_v7_neon',
+      'Nexus7v2':      'arm_v7_neon',
       'Nexus9':        'arm64',
       'NexusPlayer':   'x86',
     }[builder_dict['model']]
@@ -247,6 +248,25 @@ def device_cfg(builder_dict):
 
 
 cov_skip.extend([lineno(), lineno() + 1])
+def product_board(builder_dict):
+  if 'Android' in builder_dict.get('os', ''):
+    return {
+      'AndroidOne':    '', # This comes up empty?!?!

[rmistry, 2016/03/31 18:49:16]

Nit: 2 spaces before comment.
Also do you want to put a TODO(borenet) here or just leave it like this.

[kjlubick, 2016/03/31 18:50:11]

We should plug one of these into a swarming slave and see how it registers it.

[borenet, 2016/03/31 18:54:49]

Agreed, this and the Shield, at least temporarily.  Do you mind subbing them out
on the RPI?  It should be quick to find this out.  I don't want to commit this
without some value for that string.

[kjlubick, 2016/04/01 12:07:38]

Android one is probably "sprout", although swarming needs to be patched because
the AndroidOne is a special snowflake of a device (read: inconsistent) 

[borenet, 2016/04/01 13:47:57]

Opted for None at the moment.  We can do plenty of testing without these
devices.

+      'GalaxyS3':      'smdk4x12',
+      'GalaxyS4':      '',
+      'NVIDIA_Shield': '', # This comes up empty?!?!

[rmistry, 2016/03/31 18:49:16]

Same comment.

+      'Nexus10':       'manta',
+      'Nexus5':        'hammerhead',
+      'Nexus6':        'shamu',
+      'Nexus7':        'grouper',
+      'Nexus7v2':      'flo',
+      'Nexus9':        'flounder',
+      'NexusPlayer':   'fugu',
+    }[builder_dict['model']]
+  return None
+
+
+cov_skip.extend([lineno(), lineno() + 1])
 def get_builder_spec(builder_name):
   builder_dict = builder_name_schema.DictForBuilderName(builder_name)
   env = get_extra_env_vars(builder_dict)
@@ -263,6 +283,9 @@ def get_builder_spec(builder_name):
   device = device_cfg(builder_dict)
   if device:
     rv['device_cfg'] = device
+  board = product_board(builder_dict)
+  if board:
+    rv['product.board'] = board

[rmistry, 2016/03/31 18:49:16]

Nit: Is rv['product.board'] = None ok? if yes then you could do
rv['product.board'] = product_board(builder_dict)

[borenet, 2016/03/31 18:54:49]

I only want to fill in that field if it's valid.

 
   role = builder_dict['role']
   if role == builder_name_schema.BUILDER_ROLE_HOUSEKEEPER: