Support for Android Swarming bots

Support for Android Swarming bots

BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819033002

Committed: https://skia.googlesource.com/skia/+/cafbfe65a0da2af2caeeba1577c45925374b7d77

[borenet2, 2016-03-21 18:14:46]

Description was changed from

==========
Support for Android Swarming bots

BUG=skia:4763
==========

to

==========
Support for Android Swarming bots

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-03-31 18:38:28]

borenet@google.com changed reviewers:
+ borenet@google.com, kjlubick@google.com, rmistry@google.com

[rmistry, 2016-03-31 18:49:16]

lgtm

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py...
tools/buildbot_spec.py:254: 'AndroidOne':    '', # This comes up empty?!?!
Nit: 2 spaces before comment.
Also do you want to put a TODO(borenet) here or just leave it like this.

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py...
tools/buildbot_spec.py:257: 'NVIDIA_Shield': '', # This comes up empty?!?!
Same comment.

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py...
tools/buildbot_spec.py:288: rv['product.board'] = board
Nit: Is rv['product.board'] = None ok? if yes then you could do
rv['product.board'] = product_board(builder_dict)

[kjlubick, 2016-03-31 18:50:12]

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py...
tools/buildbot_spec.py:254: 'AndroidOne':    '', # This comes up empty?!?!
We should plug one of these into a swarming slave and see how it registers it.

[borenet, 2016-03-31 18:54:49]

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py...
tools/buildbot_spec.py:254: 'AndroidOne':    '', # This comes up empty?!?!
On 2016/03/31 18:50:11, kjlubick wrote:
> We should plug one of these into a swarming slave and see how it registers it.

Agreed, this and the Shield, at least temporarily.  Do you mind subbing them out
on the RPI?  It should be quick to find this out.  I don't want to commit this
without some value for that string.

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py...
tools/buildbot_spec.py:288: rv['product.board'] = board
On 2016/03/31 18:49:16, rmistry wrote:
> Nit: Is rv['product.board'] = None ok? if yes then you could do
> rv['product.board'] = product_board(builder_dict)

I only want to fill in that field if it's valid.

[kjlubick, 2016-04-01 12:07:38]

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py...
tools/buildbot_spec.py:254: 'AndroidOne':    '', # This comes up empty?!?!
On 2016/03/31 at 18:54:49, borenet wrote:
> On 2016/03/31 18:50:11, kjlubick wrote:
> > We should plug one of these into a swarming slave and see how it registers
it.
> 
> Agreed, this and the Shield, at least temporarily.  Do you mind subbing them
out on the RPI?  It should be quick to find this out.  I don't want to commit
this without some value for that string.

Android one is probably "sprout", although swarming needs to be patched because
the AndroidOne is a special snowflake of a device (read: inconsistent)

[borenet, 2016-04-01 13:47:57]

PTAL at patch set 16.

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1819033002/diff/280001/tools/buildbot_spec.py...
tools/buildbot_spec.py:254: 'AndroidOne':    '', # This comes up empty?!?!
On 2016/04/01 12:07:38, kjlubick wrote:
> On 2016/03/31 at 18:54:49, borenet wrote:
> > On 2016/03/31 18:50:11, kjlubick wrote:
> > > We should plug one of these into a swarming slave and see how it registers
> it.
> > 
> > Agreed, this and the Shield, at least temporarily.  Do you mind subbing them
> out on the RPI?  It should be quick to find this out.  I don't want to commit
> this without some value for that string.
> 
> Android one is probably "sprout", although swarming needs to be patched
because
> the AndroidOne is a special snowflake of a device (read: inconsistent) 

Opted for None at the moment.  We can do plenty of testing without these
devices.

[borenet, 2016-04-01 14:04:09]

The CQ bit was checked by borenet@google.com

[borenet, 2016-04-01 14:04:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/1819033002/#ps300001
(title: "Skip some devices for now")

[commit-bot: I haz the power, 2016-04-01 14:04:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819033002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819033002/300001

[kjlubick, 2016-04-01 14:15:03]

lgtm

[commit-bot: I haz the power, 2016-04-01 14:18:30]

Description was changed from

==========
Support for Android Swarming bots

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Support for Android Swarming bots

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/cafbfe65a0da2af2caeeba1577c45925374b7d77
==========

[commit-bot: I haz the power, 2016-04-01 14:18:31]

Committed patchset #16 (id:300001) as
https://skia.googlesource.com/skia/+/cafbfe65a0da2af2caeeba1577c45925374b7d77