Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: Source/bindings/scripts/generate-bindings.pl

Issue 18190004: Add Python flow to bindings generation, move dummy-generating IDL files over (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak similarity Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/generate-bindings.pl
diff --git a/Source/bindings/scripts/generate-bindings.pl b/Source/bindings/scripts/generate-bindings.pl
index e1ea014366d7f9b2d2746048ded6fd223eb1dd24..112082faf9b3d678a030c31260d4985a5f4e8c38 100755
--- a/Source/bindings/scripts/generate-bindings.pl
+++ b/Source/bindings/scripts/generate-bindings.pl
@@ -21,13 +21,6 @@
# Boston, MA 02110-1301, USA.
#
-# This script is a temporary hack.
-# Files are generated in the source directory, when they really should go
-# to the DerivedSources directory.
-# This should also eventually be a build rule driven off of .idl files
-# however a build rule only solution is blocked by several radars:
-# <rdar://problems/4251781&4251785>
-
Nils Barth (inactive) 2013/07/08 05:24:38 This comment is out of date. generate-bindings.pl/
use strict;
use File::Path;
@@ -43,7 +36,6 @@ use IDLSerializer;
my @idlDirectories;
my $outputDirectory;
my $defines;
-my $filename;
Nils Barth (inactive) 2013/07/08 05:24:38 Unused, remove.
my $preprocessor;
my $verbose;
my $supplementalDependencyFile;
@@ -54,7 +46,6 @@ my $writeFileOnlyIfChanged;
GetOptions('include=s@' => \@idlDirectories,
'outputDir=s' => \$outputDirectory,
'defines=s' => \$defines,
- 'filename=s' => \$filename,
'preprocessor=s' => \$preprocessor,
'verbose' => \$verbose,
'supplementalDependencyFile=s' => \$supplementalDependencyFile,

Powered by Google App Engine
This is Rietveld 408576698