Account for zoom when computing SVG font size.

Account for zoom when computing SVG font size.

Previously, text that was zoomed appeared larger than geometry under
the same zoom value. This was caused by two bugs:
1) When setting the computed font size, we incorrectly referenced the
computedTextSize instead of the specified size.
2) Text with GeometricPrecision did not set a computed size but
instead relied on the text size being correct.

This change addresses both of these issues and adds a test to
prove correctness.

BUG=245996
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153683

[Stephen Chennney, 2013-07-08 13:16:27]

Almost.

https://codereview.chromium.org/18190003/diff/1/Source/core/rendering/svg/Ren...
File Source/core/rendering/svg/RenderSVGInlineText.cpp (right):

https://codereview.chromium.org/18190003/diff/1/Source/core/rendering/svg/Ren...
Source/core/rendering/svg/RenderSVGInlineText.cpp:228: // Alter font-size to the
right on-screen value to avoid scaling the glyphs themselves, except when
GeometricPrecision is specified.
Save a little work.

scalingFactor = 1;
if (...textRenderingMode() != GeometricPrecision) {
   scalingFactor = SVGRendering ...
   ....
}

[pdr., 2013-07-08 14:06:56]

On 2013/07/08 13:16:27, Stephen Chenney wrote:
> Almost.
> 
>
https://codereview.chromium.org/18190003/diff/1/Source/core/rendering/svg/Ren...
> File Source/core/rendering/svg/RenderSVGInlineText.cpp (right):
> 
>
https://codereview.chromium.org/18190003/diff/1/Source/core/rendering/svg/Ren...
> Source/core/rendering/svg/RenderSVGInlineText.cpp:228: // Alter font-size to
the
> right on-screen value to avoid scaling the glyphs themselves, except when
> GeometricPrecision is specified.
> Save a little work.
> 
> scalingFactor = 1;
> if (...textRenderingMode() != GeometricPrecision) {
>    scalingFactor = SVGRendering ...
>    ....
> }

I don't think this will work while maintaining the fast-path of
scalingFactor==1. Can you double check?

[Stephen Chennney, 2013-07-08 14:11:25]

You're right. LGTM

[commit-bot: I haz the power, 2013-07-08 14:44:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/18190003/1

[commit-bot: I haz the power, 2013-07-08 16:10:12]

Change committed as 153683