Issue 1818933003: Version 5.0.71.22 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1818933003: Version 5.0.71.22 (cherry-pick) (Closed)

Created:
4 years, 9 months ago by Camillo Bruni

Modified:
4 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0

Target Ref:
refs/pending/branch-heads/5.0

Project:
v8

Visibility:
Public.

Version 5.0.71.22 (cherry-pick) Merged 96a2bd8ae8c25e2acbe63319011cbb829b59e3df [builtins] Fix Array.prototype.concat bug BUG=chromium:594574 LOG=N R=jkummerow@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/5424175c3ad321173f6046e29f4fe3be46613415

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -57 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/builtins.cc	View	11 chunks	+49 lines, -36 lines	0 comments	Download
M	src/elements.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/elements.cc	View	5 chunks	+42 lines, -0 lines	0 comments	Download
M	test/mjsunit/array-concat.js	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	test/mjsunit/es6/array-concat.js	View	1 chunk	+12 lines, -20 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-594574-concat-leak-1.js	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-594574-concat-leak-2.js	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Camillo Bruni

4 years, 9 months ago (2016-03-22 10:04:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5424175c3ad321173f6046e29f4fe3be46613415.