[DevTools] Fix to double wrapping IPv6 in square brackets

[DevTools] Fix to double wrapping IPv6 in square brackets

Removed DevTools code that added square brackets around IPv6 addresses.

Also adjusted test script to allow IPv6 localhost's [::1] ip address for
testing.

BUG=595443
R=lushnikov

Committed: https://crrev.com/c0d55a9bbafc294cd1ab29521a3c7e45eb40800c
Cr-Commit-Position: refs/heads/master@{#386218}

[allada, 2016-03-21 22:01:09]

allada@chromium.org changed reviewers:
+ pfeldman@chromium.org

[allada, 2016-03-21 22:01:09]

PTL

(because of mixup with @google vs @chromium account here is old cl:
https://codereview.chromium.org/1812613003/ )

[pfeldman, 2016-03-21 23:56:01]

lgtm

[allada, 2016-03-21 23:56:49]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-03-21 23:57:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 23:57:30]

This CL has an open dependency (Issue 1818193002 Patch 1). Please resolve the
dependency and try again.

[allada, 2016-03-29 02:32:19]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 02:32:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/1

[commit-bot: I haz the power, 2016-03-29 02:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 02:34:33]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[allada, 2016-03-29 16:47:08]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 16:47:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/20001

[commit-bot: I haz the power, 2016-03-29 17:51:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 17:51:29]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[allada, 2016-03-31 23:26:36]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 23:27:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/60001

[commit-bot: I haz the power, 2016-03-31 23:30:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 23:30:21]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[allada, 2016-04-01 01:05:35]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 01:06:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/80001

[commit-bot: I haz the power, 2016-04-01 07:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 07:08:22]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[allada, 2016-04-01 22:07:27]

The CQ bit was checked by allada@chromium.org

[allada, 2016-04-01 22:07:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1818923004/#ps80001
(title: "fix conflicts")

[commit-bot: I haz the power, 2016-04-01 22:07:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/80001

[pfeldman, 2016-04-01 22:08:10]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-04-01 22:08:37]

You should instead skip the test.

[caseq, 2016-04-04 21:25:35]

On 2016/04/01 22:08:37, pfeldman wrote:
> You should instead skip the test.

Why, can we just normalize the test output with a custom formatter?

[caseq, 2016-04-04 22:20:33]

On 2016/04/04 21:25:35, caseq wrote:
> On 2016/04/01 22:08:37, pfeldman wrote:
> > You should instead skip the test.
> 
> Why, can we just normalize the test output with a custom formatter?

(to summarize off-line discussion with pfeldman and clarify original
suggestion): it would be quite unfortunate to disable otherwise good test
because of lack of IPv6 support on some bots, so please just introduce a
separate test to cover IPv6 specific logic. Also, I guess rather than skipping
it on certain platforms we could move the verification logic to the code (i.e.
only output PASS/FAIL, don't dump actual address) and pretend the test succeeded
in case IPv6 is not available.

[allada, 2016-04-07 23:21:50]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 23:22:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/140001

[commit-bot: I haz the power, 2016-04-07 23:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 23:58:07]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[allada, 2016-04-08 00:59:08]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 00:59:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/160001

[commit-bot: I haz the power, 2016-04-08 02:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 02:14:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[allada, 2016-04-08 17:36:25]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 17:36:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/180001

[commit-bot: I haz the power, 2016-04-08 19:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 19:49:40]

Dry run: This issue passed the CQ dry run.

[allada, 2016-04-08 21:59:49]

The CQ bit was checked by allada@chromium.org

[allada, 2016-04-08 21:59:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1818923004/#ps180001
(title: "Added rule in test expectations")

[commit-bot: I haz the power, 2016-04-08 22:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818923004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818923004/180001

[commit-bot: I haz the power, 2016-04-08 22:07:00]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-04-08 22:08:01]

Description was changed from

==========
[DevTools] Fix to double wrapping IPv6 in square brackets

Removed DevTools code that added square brackets around IPv6 addresses.

Also adjusted test script to allow IPv6 localhost's [::1] ip address for
testing.

BUG=595443
R=lushnikov
==========

to

==========
[DevTools] Fix to double wrapping IPv6 in square brackets

Removed DevTools code that added square brackets around IPv6 addresses.

Also adjusted test script to allow IPv6 localhost's [::1] ip address for
testing.

BUG=595443
R=lushnikov

Committed: https://crrev.com/c0d55a9bbafc294cd1ab29521a3c7e45eb40800c
Cr-Commit-Position: refs/heads/master@{#386218}
==========

[commit-bot: I haz the power, 2016-04-08 22:08:02]

Patchset 10 (id:??) landed as
https://crrev.com/c0d55a9bbafc294cd1ab29521a3c7e45eb40800c
Cr-Commit-Position: refs/heads/master@{#386218}