Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: src/compiler/verifier.cc

Issue 1818923002: [stubs] Split ToNumberStub into reusable subparts. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 687 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 CheckUpperIs(node, Type::Number()); 698 CheckUpperIs(node, Type::Number());
699 break; 699 break;
700 case IrOpcode::kStringEqual: 700 case IrOpcode::kStringEqual:
701 case IrOpcode::kStringLessThan: 701 case IrOpcode::kStringLessThan:
702 case IrOpcode::kStringLessThanOrEqual: 702 case IrOpcode::kStringLessThanOrEqual:
703 // (String, String) -> Boolean 703 // (String, String) -> Boolean
704 CheckValueInputIs(node, 0, Type::String()); 704 CheckValueInputIs(node, 0, Type::String());
705 CheckValueInputIs(node, 1, Type::String()); 705 CheckValueInputIs(node, 1, Type::String());
706 CheckUpperIs(node, Type::Boolean()); 706 CheckUpperIs(node, Type::Boolean());
707 break; 707 break;
708 case IrOpcode::kStringToNumber:
709 // String -> Number
710 CheckValueInputIs(node, 0, Type::String());
711 CheckUpperIs(node, Type::Number());
712 break;
708 case IrOpcode::kReferenceEqual: { 713 case IrOpcode::kReferenceEqual: {
709 // (Unique, Any) -> Boolean and 714 // (Unique, Any) -> Boolean and
710 // (Any, Unique) -> Boolean 715 // (Any, Unique) -> Boolean
711 CheckUpperIs(node, Type::Boolean()); 716 CheckUpperIs(node, Type::Boolean());
712 break; 717 break;
713 } 718 }
714 case IrOpcode::kObjectIsNumber: 719 case IrOpcode::kObjectIsNumber:
715 case IrOpcode::kObjectIsReceiver: 720 case IrOpcode::kObjectIsReceiver:
716 case IrOpcode::kObjectIsSmi: 721 case IrOpcode::kObjectIsSmi:
717 case IrOpcode::kObjectIsUndetectable: 722 case IrOpcode::kObjectIsUndetectable:
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
1279 replacement->op()->EffectOutputCount() > 0); 1284 replacement->op()->EffectOutputCount() > 0);
1280 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1285 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1281 replacement->opcode() == IrOpcode::kFrameState); 1286 replacement->opcode() == IrOpcode::kFrameState);
1282 } 1287 }
1283 1288
1284 #endif // DEBUG 1289 #endif // DEBUG
1285 1290
1286 } // namespace compiler 1291 } // namespace compiler
1287 } // namespace internal 1292 } // namespace internal
1288 } // namespace v8 1293 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698