content/common/gpu/media/DEPS - Issue 1818903004: Bitrate controller for VideoToolbox Video Encode Accelerator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/gpu/media/DEPS

Issue 1818903004: Bitrate controller for VideoToolbox Video Encode Accelerator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+media",	2 "+media",

3 "+third_party/libva",	3 "+third_party/libva",

4 "+third_party/libyuv",	4 "+third_party/libyuv",

5 "+ui/display/chromeos",	5 "+ui/display/chromeos",

6 "+ui/display/types",	6 "+ui/display/types",

7 "+ui/platform_window",	7 "+ui/platform_window",

8 "+third_party/v4l-utils",	8 "+third_party/v4l-utils",

	9 "+third_party/webrtc",
	kjellander_chromium 2016/04/29 10:27:03 Oh, I've never seen that presubmit error before. I Oh, I've never seen that presubmit error before. It seems the check is actually looking at owners inside this directory. Unfortunately https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... doesn't have any owners (except for certain files), I suggest you change this to third_party/webrtc/common_video instead, and let's ask Stefan to approve with his stefan@webrtc.org account. emircan 2016/04/29 17:15:01 Thanks. It makes more sense now. I thought your @w Show quoted text On 2016/04/29 10:27:03, kjellander (chromium) wrote: > Oh, I've never seen that presubmit error before. It seems the check is actually > looking at owners inside this directory. Unfortunately > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... > doesn't have any owners (except for certain files), I suggest you change this to > third_party/webrtc/common_video instead, and let's ask Stefan to approve with > his mailto:stefan@webrtc.org account. Thanks. It makes more sense now. I thought your @webrtc.org account would be high level owner due to l.8. Adding specific webrtc folders now.
9 ]	10 ]

OLD	NEW

« no previous file with comments | « content/common/BUILD.gn ('k') | content/common/gpu/media/vt_video_encode_accelerator_mac.h » ('j') | no next file with comments »