Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: components/content_settings/core/browser/host_content_settings_map.h

Issue 1818843002: Rename SetContentSetting() to SetContentSettingCustomScope() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment alignment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/host_content_settings_map.h
diff --git a/components/content_settings/core/browser/host_content_settings_map.h b/components/content_settings/core/browser/host_content_settings_map.h
index 927305765c5d708efa37b1f53d6afcfbffb2260c..beec7ce0be171fd4b2bd0e4b4ffbb3a0a7e17956 100644
--- a/components/content_settings/core/browser/host_content_settings_map.h
+++ b/components/content_settings/core/browser/host_content_settings_map.h
@@ -142,11 +142,12 @@ class HostContentSettingsMap : public content_settings::Observer,
// data types please use the method SetWebsiteSettingDefaultScope().
//
// This should only be called on the UI thread.
- void SetContentSetting(const ContentSettingsPattern& primary_pattern,
- const ContentSettingsPattern& secondary_pattern,
- ContentSettingsType content_type,
- const std::string& resource_identifier,
- ContentSetting setting);
+ void SetContentSettingCustomScope(
+ const ContentSettingsPattern& primary_pattern,
+ const ContentSettingsPattern& secondary_pattern,
+ ContentSettingsType content_type,
+ const std::string& resource_identifier,
+ ContentSetting setting);
// Sets the content |setting| for the default scope of the url that is
// appropriate for the given |content_type| and |resource_identifier|.
@@ -159,10 +160,10 @@ class HostContentSettingsMap : public content_settings::Observer,
//
// This should only be called on the UI thread.
//
- // Internally this will call SetContentSetting() with the default scope
- // patterns for the given |content_type|. Developers will generally want
- // to use this function instead of SetContentSetting() unless they need
- // to specify custom scoping.
+ // Internally this will call SetContentSettingCustomScope() with the default
+ // scope patterns for the given |content_type|. Developers will generally want
+ // to use this function instead of SetContentSettingCustomScope() unless they
+ // need to specify custom scoping.
void SetContentSettingDefaultScope(const GURL& primary_url,
const GURL& secondary_url,
ContentSettingsType content_type,

Powered by Google App Engine
This is Rietveld 408576698