Rename SetContentSetting() to SetContentSettingCustomScope()

Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and generate
patterns inside of the method. This is what most developers will want to use when
setting content settings. The original SetContentSetting(), which takes patterns,
is renamed to SetContentSettingCustomScope() to make it more clear to developers.
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
TBR= mlamouri@chromium.org, peter@chromium.org, miu@chromium.org

Committed: https://crrev.com/21436c16b59a70f1b41b1c3571981f8420d83d8e
Cr-Commit-Position: refs/heads/master@{#385636}

[lshang, 2016-03-21 04:29:09]

Description was changed from

==========
Rename SetContentSetting() to SetContentSettingCustomScope()


rename setcontentsetting

BUG=551747
==========

to

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. This method is only used for custom-scoped setting in tests or
special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each cases and minor changes are made to fix few exceptions.

BUG=551747
==========

[lshang, 2016-03-21 04:29:32]

Description was changed from

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. This method is only used for custom-scoped setting in tests or
special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each cases and minor changes are made to fix few exceptions.

BUG=551747
==========

to

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each cases and minor changes are made to fix few exceptions.

BUG=551747
==========

[lshang, 2016-03-21 04:37:37]

lshang@chromium.org changed reviewers:
+ raymes@chromium.org

[lshang, 2016-03-21 04:37:38]

Hi raymes, this CL renames SetContentSetting() to SetContentSettingCustomScope()
and lists all the exceptions that can not be converted to
SetContentSettingDefaultScope().

This CL need to be landed after all the remaining conversion CLs get landed, so
it couldn't be compiled correctly yet for now, but could you take a first look
at this and we can discuss it if you have any questions.

Thanks!:-)

[raymes, 2016-03-21 06:07:20]

This looks really good!!

https://codereview.chromium.org/1818843002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_manager_unittest.cc (right):

https://codereview.chromium.org/1818843002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_manager_unittest.cc:219:
GetHostContentSettingsMap()->SetContentSettingCustomScope(
I think we could use SetDefaultContentSetting here instead?

https://codereview.chromium.org/1818843002/diff/20001/chrome/browser/push_mes...
File chrome/browser/push_messaging/push_messaging_browsertest.cc (right):

https://codereview.chromium.org/1818843002/diff/20001/chrome/browser/push_mes...
chrome/browser/push_messaging/push_messaging_browsertest.cc:1089:
->SetContentSettingCustomScope(ContentSettingsPattern::Wildcard(),
nit: I think we could use SetDefaultContentSetting here too?

[lshang, 2016-03-22 01:26:54]

https://codereview.chromium.org/1818843002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_manager_unittest.cc (right):

https://codereview.chromium.org/1818843002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_manager_unittest.cc:219:
GetHostContentSettingsMap()->SetContentSettingCustomScope(
On 2016/03/21 06:07:20, raymes wrote:
> I think we could use SetDefaultContentSetting here instead?

Done.

https://codereview.chromium.org/1818843002/diff/20001/chrome/browser/push_mes...
File chrome/browser/push_messaging/push_messaging_browsertest.cc (right):

https://codereview.chromium.org/1818843002/diff/20001/chrome/browser/push_mes...
chrome/browser/push_messaging/push_messaging_browsertest.cc:1089:
->SetContentSettingCustomScope(ContentSettingsPattern::Wildcard(),
On 2016/03/21 06:07:20, raymes wrote:
> nit: I think we could use SetDefaultContentSetting here too?

Done.

[raymes, 2016-03-22 05:40:13]

lgtm

https://codereview.chromium.org/1818843002/diff/40001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/fullscreen_controller.cc (right):

https://codereview.chromium.org/1818843002/diff/40001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/fullscreen_controller.cc:509: // the
nit: fill 80 chars

[lshang, 2016-04-05 09:25:46]

Description was changed from

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each cases and minor changes are made to fix few exceptions.

BUG=551747
==========

to

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
==========

[lshang, 2016-04-06 00:03:21]

Hi Raymes, some more changes are made due to trunk update in these days. Can you
confirm the change? Thanks!

[raymes, 2016-04-06 06:02:41]

lgtm but still with a nit I think :)

https://codereview.chromium.org/1818843002/diff/80001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/fullscreen_controller.cc (right):

https://codereview.chromium.org/1818843002/diff/80001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/fullscreen_controller.cc:509: // the
nit: fill 80 chars

[lshang, 2016-04-06 10:44:23]

https://codereview.chromium.org/1818843002/diff/80001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/fullscreen_controller.cc (right):

https://codereview.chromium.org/1818843002/diff/80001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/fullscreen_controller.cc:509: // the
On 2016/04/06 06:02:40, raymes wrote:
> nit: fill 80 chars

Done.
Always forget to adjust comments after 'git cl format'(┬＿┬)

[lshang, 2016-04-06 10:59:16]

lshang@chromium.org changed reviewers:
+ bauerb@chromium.org, johnme@chromium.org, miu@chromium.org,
mlamouri@chromium.org, peter@chromium.org

[lshang, 2016-04-06 10:59:17]

+OWNER

@bauerb: please review changes in 
   c/b/android/
   c/b/plugins/
   c/b/ui/webui/
@peter: please review changes in c/b/notifications/
@mlamouri: please review changes in c/b/permissions/
@johnme: please review changes in c/b/push_messaging/
@miu: please review changes in c/b/ui/exclusive_access/

Thanks!

[johnme, 2016-04-06 12:45:08]

c/b/permissions/ lgtm

[johnme, 2016-04-06 12:45:34]

On 2016/04/06 12:45:08, johnme wrote:
> c/b/permissions/ lgtm

Oops, I mean c/b/push_messaging/ lgtm!

[Bernhard Bauer, 2016-04-06 14:34:48]

LGTM

FWIW, you can actually TBR OWNERS where you are just updating call sites, if the
base change has been approved.

[lshang, 2016-04-07 01:14:17]

Description was changed from

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
==========

to

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
TBR=mlamouri@chromium.org, peter@chromium.org, miu@chromium.org
==========

[lshang, 2016-04-07 01:17:36]

Description was changed from

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
TBR=mlamouri@chromium.org, peter@chromium.org, miu@chromium.org
==========

to

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
TBR= mlamouri@chromium.org, peter@chromium.org, miu@chromium.org
==========

[lshang, 2016-04-07 01:19:31]

The CQ bit was checked by lshang@chromium.org

[lshang, 2016-04-07 01:19:31]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1818843002/#ps100001
(title: "minor change")

[commit-bot: I haz the power, 2016-04-07 01:20:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818843002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818843002/100001

[commit-bot: I haz the power, 2016-04-07 02:59:23]

Description was changed from

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
TBR= mlamouri@chromium.org, peter@chromium.org, miu@chromium.org
==========

to

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
TBR= mlamouri@chromium.org, peter@chromium.org, miu@chromium.org
==========

[commit-bot: I haz the power, 2016-04-07 02:59:25]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-07 03:01:34]

Description was changed from

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate 
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns, 
is renamed to SetContentSettingCustomScope() to make it more clear to
developers. 
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i 
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
TBR= mlamouri@chromium.org, peter@chromium.org, miu@chromium.org
==========

to

==========
Rename SetContentSetting() to SetContentSettingCustomScope()

We made a SetContentSettingDefaultScope() which takes GURLs directly and
generate
patterns inside of the method. This is what most developers will want to use
when
setting content settings. The original SetContentSetting(), which takes
patterns,
is renamed to SetContentSettingCustomScope() to make it more clear to
developers.
This method is only used for custom-scoped setting in tests or special cases.

To rename it, first use command:

grep -rl 'SetContentSetting(' ./* | xargs sed -i
's/SetContentSetting(/SetContentSettingcustomScope(/g'

to find out all the call sites of SetContentSetting() and rename them. Then give
a review of each case and minor changes are made to fix few exceptions.

BUG=551747
TBR= mlamouri@chromium.org, peter@chromium.org, miu@chromium.org

Committed: https://crrev.com/21436c16b59a70f1b41b1c3571981f8420d83d8e
Cr-Commit-Position: refs/heads/master@{#385636}
==========

[commit-bot: I haz the power, 2016-04-07 03:01:35]

Patchset 6 (id:??) landed as
https://crrev.com/21436c16b59a70f1b41b1c3571981f8420d83d8e
Cr-Commit-Position: refs/heads/master@{#385636}