Cache library closure hashes and absolute URIs.

Cache library closure hashes and absolute URIs.

Remove the concrete CacheStorage implementation (will add it to
analyzer_cli later).

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/4ec1f2bfb921302ba9902fe12173ab38e2d3edac

[Paul Berry, 2016-03-21 20:29:32]

lgtm

https://codereview.chromium.org/1818823005/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (left):

https://codereview.chromium.org/1818823005/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:42: class FolderCacheStorage
implements CacheStorage {
I'm not sure I agree with the idea of removing this from analyzer and adding it
to analyzer_cli later.  It seems like the analysis server could make use of this
class in the future (and perhaps also DDC).  If we move it to analyzer_cli, it
will only be accessible to analyzer_cli.

https://codereview.chromium.org/1818823005/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1818823005/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:283: if
(containedUri.startsWith('dart:') ||
If the goal is to figure out whether this is an absolute URI, why not use
Uri.isAbsolute?

[scheglov, 2016-03-21 20:58:26]

https://codereview.chromium.org/1818823005/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (left):

https://codereview.chromium.org/1818823005/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:42: class FolderCacheStorage
implements CacheStorage {
On 2016/03/21 20:29:32, Paul Berry wrote:
> I'm not sure I agree with the idea of removing this from analyzer and adding
it
> to analyzer_cli later.  It seems like the analysis server could make use of
this
> class in the future (and perhaps also DDC).  If we move it to analyzer_cli, it
> will only be accessible to analyzer_cli.

OK, restored.

https://codereview.chromium.org/1818823005/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1818823005/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:283: if
(containedUri.startsWith('dart:') ||
On 2016/03/21 20:29:32, Paul Berry wrote:
> If the goal is to figure out whether this is an absolute URI, why not use
> Uri.isAbsolute?

See the performance results in mail.
URI operations are slow :-(

[scheglov, 2016-03-21 21:04:00]

Description was changed from

==========
Cache library closure hashes and absolute URIs.

Remove the concrete CacheStorage implementation (will add it to
analyzer_cli later).

R=paulberry@google.com
BUG=
==========

to

==========
Cache library closure hashes and absolute URIs.

Remove the concrete CacheStorage implementation (will add it to
analyzer_cli later).

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/4ec1f2bfb921302ba9902fe12173ab38e2d3edac
==========

[scheglov, 2016-03-21 21:04:02]

Committed patchset #1 (id:1) manually as
4ec1f2bfb921302ba9902fe12173ab38e2d3edac (presubmit successful).