Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 1818713002: Don't convert DWORD to int. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't convert DWORD to int. DWORD is unsigned, and might not be an int. vs2015u2 complains. BUG=skia:4553 TBR=mtklein This is pretty trivial and makes the vs2015 bot compile. Committed: https://skia.googlesource.com/skia/+/4ab57e0097b9b1fcdea7a49a01ff3d9ad993dfee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/CrashHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818713002/1
4 years, 9 months ago (2016-03-19 22:25:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-19 22:36:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818713002/1
4 years, 9 months ago (2016-03-19 22:50:15 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 22:51:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4ab57e0097b9b1fcdea7a49a01ff3d9ad993dfee

Powered by Google App Engine
This is Rietveld 408576698