Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 18187005: Sort the i18n extension sources correctly. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Sort the i18n extension sources correctly. It's important that e.g. the header comes first, and the footer last BUG=v8:2745 R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/gyp/v8.gyp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-03 13:36:04 UTC) #1
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-07-03 14:27:44 UTC) #2
Jakob Kummerow
7 years, 5 months ago (2013-07-03 15:29:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698