Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: components/data_use_measurement/content/data_use_measurement.h

Issue 1818613002: Implement UMA log throttling for cellular connections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/content/data_use_measurement.h
diff --git a/components/data_use_measurement/content/data_use_measurement.h b/components/data_use_measurement/content/data_use_measurement.h
index a5b8f7136359a70c26fe085c11fb0471549bb004..3d9636e52d2ef7a8fdd8097094de5018a4d7cbf2 100644
--- a/components/data_use_measurement/content/data_use_measurement.h
+++ b/components/data_use_measurement/content/data_use_measurement.h
@@ -9,10 +9,12 @@
#include <string>
+#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "build/build_config.h"
#include "components/data_use_measurement/core/data_use_user_data.h"
+#include "components/metrics/data_use_tracker.h"
#if defined(OS_ANDROID)
#include "base/android/application_status_listener.h"
@@ -32,7 +34,8 @@ namespace data_use_measurement {
// http://crbug.com/527460
class DataUseMeasurement {
public:
- DataUseMeasurement();
+ explicit DataUseMeasurement(
+ const metrics::UpdateUsagePrefCallbackType& metrics_data_use_forwarder);
~DataUseMeasurement();
// Records the data use of the |request|, thus |request| must be non-null.
@@ -63,7 +66,9 @@ class DataUseMeasurement {
// ("Downstream") path, whether the app was in the "Foreground" or
// "Background", and whether a "Cellular" or "WiFi" network was use. For
// example, "Prefix.Upstream.Foreground.Cellular" is a possible output.
- std::string GetHistogramName(const char* prefix, TrafficDirection dir) const;
+ std::string GetHistogramName(const char* prefix,
+ TrafficDirection dir,
+ bool is_connection_cellular) const;
#if defined(OS_ANDROID)
// Called whenever the application transitions from foreground to background
@@ -79,8 +84,15 @@ class DataUseMeasurement {
void ReportDataUsageServices(
data_use_measurement::DataUseUserData::ServiceName service,
TrafficDirection dir,
+ bool is_connection_cellular,
int64_t message_size) const;
+ // Callback for updating data use prefs.
+ // TODO(rajendrant): If a similar mechanism would need be used for components
+ // other than metrics, then the better approach would be to refactor this
+ // class to support registering arbitrary observers. crbug.com/601185
+ metrics::UpdateUsagePrefCallbackType metrics_data_use_forwarder_;
+
#if defined(OS_ANDROID)
// Application listener store the last known state of the application in this
// field.
« no previous file with comments | « components/data_use_measurement/content/DEPS ('k') | components/data_use_measurement/content/data_use_measurement.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698