components/data_use_measurement/content/data_use_measurement_unittest.cc - Issue 1818613002: Implement UMA log throttling for cellular connections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_use_measurement/content/data_use_measurement_unittest.cc

Issue 1818613002: Implement UMA log throttling for cellular connections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_use_measurement/content/data_use_measurement.cc ('K') | « components/data_use_measurement/content/data_use_measurement.cc ('k') | components/metrics.gypi » ('j') | components/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_use_measurement/content/data_use_measurement_unittest.cc

diff --git a/components/data_use_measurement/content/data_use_measurement_unittest.cc b/components/data_use_measurement/content/data_use_measurement_unittest.cc

index 242a1aedfc50ebe0fa7f33aa92dea3ac87c841c9..d4f8753e1414d4649e1e294af0dcbaeb8264811e 100644

--- a/components/data_use_measurement/content/data_use_measurement_unittest.cc

+++ b/components/data_use_measurement/content/data_use_measurement_unittest.cc

@@ -27,7 +27,8 @@ namespace data_use_measurement {

class DataUseMeasurementTest : public testing::Test {

public:

- DataUseMeasurementTest() {

+ DataUseMeasurementTest()

+ : data_use_measurement_(metrics::UpdateUsagePrefCallbackType()) {

bengr 2016/04/06 20:57:11 Please test that the callback gets called appropri

gayane -on leave until 09-2017 2016/04/07 15:30:39 Done.

// During the test it is expected to not have cellular connection.

DCHECK(!net::NetworkChangeNotifier::IsConnectionCellular(

net::NetworkChangeNotifier::GetConnectionType()));