Implement UMA log throttling for cellular connections

components/data_use_measurement/content/data_use_measurement.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_use_measurement/content/data_use_measurement.h"
 
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/strings/stringprintf.h"
 #include "build/build_config.h"
 #include "content/public/browser/resource_request_info.h"
+#include "components/metrics/metrics_data_use_measurements.h"
 #include "net/base/network_change_notifier.h"
 #include "net/base/upload_data_stream.h"
 #include "net/http/http_response_headers.h"
 #include "net/url_request/url_request.h"
 
 namespace data_use_measurement {
 
 namespace {
 
 // Records the occurrence of |sample| in |name| histogram. Conventional UMA
@@ skipping 59 matching lines @@
                        UPSTREAM),
       total_upload_bytes);
   RecordUMAHistogramCount(
       GetHistogramName(is_user_traffic ? "DataUse.TrafficSize.User"
                                        : "DataUse.TrafficSize.System",
                        DOWNSTREAM),
       total_received_bytes);
 
   DataUseUserData* attached_service_data = reinterpret_cast<DataUseUserData*>(
       request->GetUserData(DataUseUserData::kUserDataKey));
-
+  DataUseUserData::ServiceName service_name =
+      attached_service_data ? attached_service_data->service_name()
+                            : DataUseUserData::NOT_TAGGED;
   if (!is_user_traffic) {
-    DataUseUserData::ServiceName service_name =
-        attached_service_data ? attached_service_data->service_name()
-                              : DataUseUserData::NOT_TAGGED;
     ReportDataUsageServices(service_name, UPSTREAM, total_upload_bytes);
     ReportDataUsageServices(service_name, DOWNSTREAM, total_received_bytes);
   }
+  metrics::MetricsDataUseMeasurements::GetInstance()->UpdateMetricsUsagePrefs(

[Alexei Svitkine (slow), 2016/03/18 22:23:29]

We can discuss more offline, but I would prefer the dependency be passed it to
the ctor.

Looks like the DataUseMeasurement object is owned by ChromeNetworkDelegate,
which is constructed here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...

So we can probably pass in a pointer to MetricsDataUseMeasurements() to it -
that would be owned by MetricsServicesManager. We can chat more about this on
Monday. You can wait on these changes until then so we make sure we're clear on
what needs to be done here.

[gayane -on leave until 09-2017, 2016/03/29 16:06:20]

Done.

+      attached_service_data->GetServiceNameAsString(service_name),
+      total_upload_bytes + total_received_bytes);
 }
 
 #if defined(OS_ANDROID)
 void DataUseMeasurement::OnApplicationStateChangeForTesting(
     base::android::ApplicationState application_state) {
   app_state_ = application_state;
 }
 #endif
 
 DataUseMeasurement::AppState DataUseMeasurement::CurrentAppState() const {
@@ skipping 29 matching lines @@
     int64_t message_size) const {
   RecordUMAHistogramCount(
       "DataUse.MessageSize." + DataUseUserData::GetServiceNameAsString(service),
       message_size);
   if (message_size > 0) {
     IncreaseSparseHistogramByValue(
         GetHistogramName("DataUse.MessageSize.AllServices", dir), service,
         message_size);
   }
 }
-
 }  // namespace data_use_measurement