Keep track of ChannelIDService in CookieStore

net/cookies/cookie_store.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Brought to you by number 42.
 
 #ifndef NET_COOKIES_COOKIE_STORE_H_
 #define NET_COOKIES_COOKIE_STORE_H_
 
 #include <string>
@@ skipping 188 matching lines @@
   // implementors need to be improved to not behave this way.
   virtual scoped_ptr<CookieChangedSubscription> AddCallbackForCookie(
       const GURL& url,
       const std::string& name,
       const CookieChangedCallback& callback) = 0;
 
   // Returns true if this cookie store is ephemeral, and false if it is backed
   // by some sort of persistence layer.
   // TODO(nharper): Remove this method once crbug.com/548423 has been closed.
   virtual bool IsEphemeral() = 0;
+  void SetChannelIDServiceID(int id);
+  int GetChannelIDServiceID();

[mmenke, 2016/03/28 17:54:00]

Do you plan to keep this, long term?  Why make the cookie store know about the
ChannelIDService, and not the other way around?  Not sure which is the right
dependency order, just wondering if you thought about it.

[nharper, 2016/03/29 00:30:20]

I'd like all of this debugging stuff to go away eventually (although that would
be problematic if we want to DCHECK when a mismatch happens).

The reason for having the cookie store know about the ChannelIDService is
because ChannelIDService already has an atomic sequence number for generating
these IDs - I believe I'd need to add something similar to CookieStore to have
this work the other way.

I didn't think very hard about the dependency order when I first did this, but I
think I'm convinced that this is the correct order. This set up allows for
multiple CookieStores to belong to the same ChannelIDService, which could be
fine (or could be problematic if deleting data from a CookieStore triggers
deletions from the ChannelIDService). If this is reversed, then a single
CookieStore could end up belonging to multiple ChannelIDServices, which would
always be wrong. The most robust way to ensure a 1-to-1 mapping would be to have
both know who the other is.

 
  protected:
   CookieStore();
+  int channel_id_service_id_;
 };
 
 }  // namespace net
 
 #endif  // NET_COOKIES_COOKIE_STORE_H_