Keep track of ChannelIDService in CookieStore

chrome/browser/profiles/profile_impl_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl_io_data.h"
 
 #include <set>
 #include <string>
 #include <utility>
 
@@ skipping 497 matching lines @@
             BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
                 base::SequencedWorkerPool::GetSequenceToken()),
             lazy_params_->special_storage_policy.get());
     channel_id_service = new net::ChannelIDService(
         new net::DefaultChannelIDStore(channel_id_db.get()),
         base::WorkerPool::GetTaskRunner(true));
   }
 
   set_channel_id_service(channel_id_service);
   main_context->set_channel_id_service(channel_id_service);
+  main_cookie_store_->SetChannelIDServiceID(channel_id_service->GetUniqueID());

[mmenke, 2016/03/18 22:12:56]

This seems weird.  We're calling into one ChannelIDService to get unique IDs for
other ChannelIDServices that are, otherwise, completely independent of the main
ChannelIDService.  Could we just have IOThread vend them directly or something? 
Open to other ideas.

[nharper, 2016/03/18 22:31:09]

I don't follow what you're saying here. This is setting a field in the main
cookie store to indicate that it should be used with the channel id service used
in the main context, so that it can be checked later that the expected channel
id service for the cookie store was indeed used. I don't see how this uses one
ChannelIDService to get unique IDs for other ChannelIDServices.

[mmenke, 2016/03/18 22:39:19]

Oh, "GetUniqueId()" was confusing me.  Was thinking it was generating a unique
ID, and you were assigning it to the channel ID service here.

 
   scoped_ptr<net::HttpCache::BackendFactory> main_backend(
       new net::HttpCache::DefaultBackend(
           net::DISK_CACHE,
           ChooseCacheBackendType(),
           lazy_params_->cache_path,
           lazy_params_->cache_max_size,
           BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)));
   http_network_session_ = CreateHttpNetworkSession(*profile_params);
   main_http_factory_ = CreateMainHttpFactory(http_network_session_.get(),
@@ skipping 237 matching lines @@
     const base::Closure& completion) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DCHECK(initialized());
 
   DCHECK(transport_security_state());
   // Completes synchronously.
   transport_security_state()->DeleteAllDynamicDataSince(time);
   DCHECK(http_server_properties_manager_);
   http_server_properties_manager_->Clear(completion);
 }