Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: telemetry/telemetry/internal/browser/browser.py

Issue 1818593002: [Telemetry] Always close browser backend in Close() (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/browser/browser.py
diff --git a/telemetry/telemetry/internal/browser/browser.py b/telemetry/telemetry/internal/browser/browser.py
index a36631f724807cd2e3d65a02835d3f45972fb9d8..8d65d823961f7495022117e76e4a8000d7ea411f 100644
--- a/telemetry/telemetry/internal/browser/browser.py
+++ b/telemetry/telemetry/internal/browser/browser.py
@@ -222,17 +222,19 @@ class Browser(app.App):
def Close(self):
"""Closes this browser."""
- if self._browser_backend.IsBrowserRunning():
- self._platform_backend.WillCloseBrowser(self, self._browser_backend)
+ try:
+ if self._browser_backend.IsBrowserRunning():
+ self._platform_backend.WillCloseBrowser(self, self._browser_backend)
- self._browser_backend.profiling_controller_backend.WillCloseBrowser()
- if self._browser_backend.supports_uploading_logs:
- try:
- self._browser_backend.UploadLogsToCloudStorage()
- except cloud_storage.CloudStorageError as e:
- logging.error('Cannot upload browser log: %s' % str(e))
- self._browser_backend.Close()
- self.credentials = None
+ self._browser_backend.profiling_controller_backend.WillCloseBrowser()
+ if self._browser_backend.supports_uploading_logs:
+ try:
+ self._browser_backend.UploadLogsToCloudStorage()
+ except cloud_storage.CloudStorageError as e:
+ logging.error('Cannot upload browser log: %s' % str(e))
+ finally:
+ self._browser_backend.Close()
+ self.credentials = None
def GetStandardOutput(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698