Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1818533004: Fix Chromium style plugin warning after https://codereview.chromium.org/1815063002 (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
ananta
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Chromium style plugin warning after https://codereview.chromium.org/1815063002 ..\..\content/common/gpu/media/dxva_video_decode_accelerator_win.h(445,52) : error: [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition. base::WeakPtrFactory<DXVAVideoDecodeAccelerator> weak_this_factory_; ^ BUG=82385, 594266 TBR=ananta Committed: https://chromium.googlesource.com/chromium/src/+/13b3ac887d5011ff3b3c39d0e44ca9aed1740ce8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.h View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Nico
4 years, 9 months ago (2016-03-19 13:08:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818533004/1
4 years, 9 months ago (2016-03-19 13:08:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13b3ac887d5011ff3b3c39d0e44ca9aed1740ce8 Cr-Commit-Position: refs/heads/master@{#382196}
4 years, 9 months ago (2016-03-19 13:21:27 UTC) #6
Nico
Committed patchset #1 (id:1) manually as 13b3ac887d5011ff3b3c39d0e44ca9aed1740ce8 (presubmit successful).
4 years, 9 months ago (2016-03-19 13:22:10 UTC) #8
ananta
4 years, 9 months ago (2016-03-21 18:57:17 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698