Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1818503002: [turbofan] PropagateMarks until we have no more change. (Closed)

Created:
4 years, 9 months ago by Mircea Trofin
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] PropagateMarks until we have no more change. In the frame elider, we were propagating marks if both up and down propagations were causing a change. We should do it until neither changes. BUG= Committed: https://crrev.com/9c5940deb5e8405dc4fa6f6cdce2d787b61b4360 Cr-Commit-Position: refs/heads/master@{#35013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/frame-elider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Mircea Trofin
4 years, 9 months ago (2016-03-18 18:32:55 UTC) #3
danno
lgtm. Adding a compiler OWNER for a real lgtm.
4 years, 9 months ago (2016-03-22 17:46:13 UTC) #5
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-23 05:56:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818503002/1
4 years, 9 months ago (2016-03-23 05:58:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 06:23:20 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 06:24:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c5940deb5e8405dc4fa6f6cdce2d787b61b4360
Cr-Commit-Position: refs/heads/master@{#35013}

Powered by Google App Engine
This is Rietveld 408576698