Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1818433002: 🚕 adb_gdb: Add --device flag (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
Yaron
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

adb_gdb: Add --device flag and fix it not erroring out when multiple devices are attached BUG=none Committed: https://crrev.com/cd4e139b12f45f81a77d6293f1bb9339464f80f4 Cr-Commit-Position: refs/heads/master@{#382036}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/android/adb_gdb View 1 4 chunks +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/03/18 17:14:39, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org
4 years, 9 months ago (2016-03-18 17:14:44 UTC) #3
Yaron
lgtm
4 years, 9 months ago (2016-03-18 17:23:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818433002/20001
4 years, 9 months ago (2016-03-18 18:14:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 18:56:15 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 18:57:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd4e139b12f45f81a77d6293f1bb9339464f80f4
Cr-Commit-Position: refs/heads/master@{#382036}

Powered by Google App Engine
This is Rietveld 408576698