Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1818423003: Revert of Remove configuration policy from chrome build files. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy_chrome_defines
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove configuration policy from chrome build files. (patchset #4 id:60001 of https://codereview.chromium.org/1798273002/ ) Reason for revert: Speculative revert: could have caused the Win8 GN build failures. See crbug.com/597032 Original issue's description: > Remove configuration policy from chrome build files. > > The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes. > > BUG=594261 > > Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888 > Cr-Commit-Position: refs/heads/master@{#382614} TBR=atwilson@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594261 Committed: https://crrev.com/e742862f9555579e3239d9658766081ac4729e92 Cr-Commit-Position: refs/heads/master@{#382681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -174 lines) Patch
M chrome/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 4 chunks +44 lines, -12 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/policy/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/policy/profile_policy_connector_stub.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 4 chunks +9 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 11 chunks +107 lines, -60 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 5 chunks +16 lines, -7 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +14 lines, -7 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 3 chunks +14 lines, -4 lines 0 comments Download
M chrome/chrome_exe.gypi View 4 chunks +14 lines, -2 lines 0 comments Download
M chrome/chrome_process_finder.gypi View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 6 chunks +27 lines, -16 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 17 chunks +60 lines, -25 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/policy.gypi View 1 chunk +23 lines, -19 lines 0 comments Download
M chrome/test/BUILD.gn View 8 chunks +38 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dgozman
Created Revert of Remove configuration policy from chrome build files.
4 years, 9 months ago (2016-03-22 21:16:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818423003/1
4 years, 9 months ago (2016-03-22 21:16:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 21:17:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e742862f9555579e3239d9658766081ac4729e92 Cr-Commit-Position: refs/heads/master@{#382681}
4 years, 9 months ago (2016-03-22 21:18:40 UTC) #5
dgozman
4 years, 9 months ago (2016-03-22 21:43:39 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1825603003/ by dgozman@chromium.org.

The reason for reverting is: Reland original patch, it was not the cause.

Powered by Google App Engine
This is Rietveld 408576698