Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1818373004: Run tests on the Win8 Aura bot under swarming. (Closed)

Created:
4 years, 9 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
CC:
chromium-reviews, sky, jam, msw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run tests on the Win8 Aura bot under swarming. R=wfh@chromium.org, brucedawson@chromium.org BUG=none

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove duplicated compile targets #

Patch Set 3 : guess at command lines for mojo tests #

Patch Set 4 : fix typo #

Patch Set 5 : fix path to mojo_public_application_unittests #

Patch Set 6 : try to fix the path again #

Patch Set 7 : fix mojo_runner_host_unittests path #

Patch Set 8 : try to fix mojo_runner_host_unittests again #

Patch Set 9 : fix mojo_shell, mojo_view_manager_lib #

Patch Set 10 : fix network_service_unittests #

Patch Set 11 : fix //mojo:tests dependency #

Patch Set 12 : fix label in gn_isolate_map #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -28 lines) Patch
M mojo/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -10 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 9 4 chunks +51 lines, -2 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dirk Pranke
Assuming this lands and sticks, I'll post a follow-up CL to convert as many of ...
4 years, 9 months ago (2016-03-23 00:49:30 UTC) #1
Will Harris
https://codereview.chromium.org/1818373004/diff/1/testing/buildbot/chromium.win.json File testing/buildbot/chromium.win.json (right): https://codereview.chromium.org/1818373004/diff/1/testing/buildbot/chromium.win.json#newcode1624 testing/buildbot/chromium.win.json:1624: "additional_compile_targets": [ I'm not sure we actually need any ...
4 years, 9 months ago (2016-03-23 00:53:07 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1818373004/diff/1/testing/buildbot/chromium.win.json File testing/buildbot/chromium.win.json (right): https://codereview.chromium.org/1818373004/diff/1/testing/buildbot/chromium.win.json#newcode1624 testing/buildbot/chromium.win.json:1624: "additional_compile_targets": [ On 2016/03/23 00:53:07, Will Harris wrote: > ...
4 years, 9 months ago (2016-03-23 01:04:31 UTC) #3
Will Harris
https://codereview.chromium.org/1818373004/diff/1/testing/buildbot/chromium.win.json File testing/buildbot/chromium.win.json (right): https://codereview.chromium.org/1818373004/diff/1/testing/buildbot/chromium.win.json#newcode1624 testing/buildbot/chromium.win.json:1624: "additional_compile_targets": [ On 2016/03/23 01:04:31, Dirk Pranke wrote: > ...
4 years, 9 months ago (2016-03-23 01:07:01 UTC) #4
Dirk Pranke
On 2016/03/23 01:07:01, Will Harris wrote: > https://codereview.chromium.org/1818373004/diff/1/testing/buildbot/chromium.win.json > File testing/buildbot/chromium.win.json (right): > > https://codereview.chromium.org/1818373004/diff/1/testing/buildbot/chromium.win.json#newcode1624 ...
4 years, 9 months ago (2016-03-23 21:46:18 UTC) #5
Dirk Pranke
4 years, 8 months ago (2016-03-28 22:40:54 UTC) #7
closing ... I'll let one of the Mojo folks pick this up in a new CL to make
whatever other changes are needed ...

Powered by Google App Engine
This is Rietveld 408576698