Move serialize/deserialize logic onto Entry.

mojo/services/catalog/entry.h

Index: mojo/services/catalog/entry.h
diff --git a/mojo/services/catalog/entry.h b/mojo/services/catalog/entry.h
index 4b7ffa803d5040feb7e22519b42e1e568bc33655..4aaae33896cf942947a1b39bddf57de56430bb48 100644
--- a/mojo/services/catalog/entry.h
+++ b/mojo/services/catalog/entry.h
@@ -7,22 +7,52 @@
 
 #include <string>
 
+#include "base/memory/scoped_ptr.h"
 #include "mojo/shell/public/cpp/capabilities.h"
 
+namespace base {
+class DictionaryValue;
+}
+
 namespace catalog {
 
 // Static information about an application package known to the Catalog.
-struct Entry {
+class Entry {
+ public:
+  enum class DeserializeResult {
+    SUCCESS,
+    INVALID_DICTIONARY,
+    INVALID_NAME
+  };
+
   Entry();
-  Entry(const Entry& other);
+  explicit Entry(const Entry& other);
   ~Entry();
 
+  scoped_ptr<base::DictionaryValue> Serialize() const;
+  static DeserializeResult Deserialize(const base::DictionaryValue& value,

[sky, 2016/03/22 15:10:03]

It seems like you only check the return value for SUCCESS. WDYT of having this
return a scoped_ptr<Entry> and on failure return null? Or did I miss where you
differentiate the return value?

+                                       Entry* entry);
+
   bool operator==(const Entry& other) const;
 
-  std::string name;
-  std::string qualifier;
-  std::string display_name;
-  mojo::CapabilitySpec capabilities;
+  const std::string& name() const { return name_; }
+  void set_name(const std::string& name) { name_ = name; }
+  const std::string& qualifier() const { return qualifier_; }
+  void set_qualifier(const std::string& qualifier) { qualifier_ = qualifier; }
+  const std::string& display_name() const { return display_name_; }
+  void set_display_name(const std::string& display_name) {
+    display_name_ = display_name;
+  }
+  const mojo::CapabilitySpec& capabilities() const { return capabilities_; }
+  void set_capabilities(const mojo::CapabilitySpec& capabilities) {
+    capabilities_ = capabilities;
+  }
+
+ private:
+  std::string name_;
+  std::string qualifier_;
+  std::string display_name_;
+  mojo::CapabilitySpec capabilities_;
 };
 
 }  // namespace catalog