components/mus/public/cpp/lib/window.cc - Issue 1818333002: Reland: mus: Enable system modal windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/lib/window.cc

Issue 1818333002: Reland: mus: Enable system modal windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleaned up comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/public/cpp/lib/window.cc

diff --git a/components/mus/public/cpp/lib/window.cc b/components/mus/public/cpp/lib/window.cc

index 688aa54b2b566cfc99ee39985b9d58a2dac3b203..d1b4cb6485bcae8bd2d2f055a2b48e504f778b03 100644

--- a/components/mus/public/cpp/lib/window.cc

+++ b/components/mus/public/cpp/lib/window.cc

@@ -341,6 +341,9 @@ bool Window::Contains(const Window* child) const {

}

void Window::AddTransientWindow(Window* transient_window) {

+ // A system modal window cannot become a transient child.

+ DCHECK(!transient_window->is_modal() || transient_window->transient_parent());

if (connection_)

CHECK_EQ(transient_window->connection(), connection_);

LocalAddTransientWindow(transient_window);