Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: components/mus/ws/server_window.cc

Issue 1818333002: Reland: mus: Enable system modal windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/ws/server_window.cc
diff --git a/components/mus/ws/server_window.cc b/components/mus/ws/server_window.cc
index eeb5d7d44929e0275c949faff176438dcd2b5b56..3cd72ceb10144a7ce627d7cb578b6fe84592e4ea 100644
--- a/components/mus/ws/server_window.cc
+++ b/components/mus/ws/server_window.cc
@@ -18,28 +18,6 @@ namespace mus {
namespace ws {
-namespace {
-
-const ServerWindow* GetModalChildForWindowAncestor(const ServerWindow* window) {
- for (const ServerWindow* ancestor = window; ancestor;
- ancestor = ancestor->parent()) {
- for (const auto& transient_child : ancestor->transient_children()) {
- if (transient_child->is_modal() && transient_child->IsDrawn())
- return transient_child;
- }
- }
- return nullptr;
-}
-
-const ServerWindow* GetModalTargetForWindow(const ServerWindow* window) {
- const ServerWindow* modal_window = GetModalChildForWindowAncestor(window);
- if (!modal_window)
- return window;
- return GetModalTargetForWindow(modal_window);
-}
-
-} // namespace
-
ServerWindow::ServerWindow(ServerWindowDelegate* delegate, const WindowId& id)
: ServerWindow(delegate, id, Properties()) {}
@@ -229,6 +207,9 @@ ServerWindow* ServerWindow::GetChildWindow(const WindowId& window_id) {
}
void ServerWindow::AddTransientWindow(ServerWindow* child) {
+ // A system modal window cannot become a transient child.
+ DCHECK(!child->is_modal() || child->transient_parent());
+
if (child->transient_parent())
child->transient_parent()->RemoveTransientWindow(child);
@@ -268,14 +249,6 @@ void ServerWindow::SetModal() {
is_modal_ = true;
}
-bool ServerWindow::IsBlockedByModalWindow() const {
- return !!GetModalChildForWindowAncestor(this);
-}
-
-const ServerWindow* ServerWindow::GetModalTarget() const {
- return GetModalTargetForWindow(this);
-}
-
bool ServerWindow::Contains(const ServerWindow* window) const {
for (const ServerWindow* parent = window; parent; parent = parent->parent_) {
if (parent == this)

Powered by Google App Engine
This is Rietveld 408576698