Reland: mus: Enable system modal windows

components/mus/public/interfaces/window_tree.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module mus.mojom;
 
 import "components/mus/public/interfaces/compositor_frame.mojom";
 import "components/mus/public/interfaces/cursor.mojom";
 import "components/mus/public/interfaces/input_events.mojom";
 import "components/mus/public/interfaces/input_event_matcher.mojom";
@@ skipping 152 matching lines @@
   // Removes a window from its current parent. This fails if the window is not
   // valid or the window already has no parent.
   //
   // Removing a window from a parent may result in OnWindowDeleted() being sent
   // to other connections. For example, connection A has windows 1 and 2, with 2
   // a child of 1. Connection B has a root 1. If 2 is removed from 1 then B gets
   // OnWindowDeleted(). This is done as window 2 is effectively no longer
   // visible to connection B.
   RemoveWindowFromParent(uint32 change_id, uint32 window_id);
 
-  // Ties the lifetime of |child| to the lifetime of |parent|. This also
-  // places |child| always on top of |parent|.
+  // Ties the lifetime of |transient_window_id| to the lifetime of |window_id|.
+  // This also places |transient_window_id| always on top of |window_id|.

[sky, 2016/04/29 00:23:18]

nit: remove 'always'.

[mohsen, 2016/04/29 03:33:37]

Done.

+  // |transient_window_id| should not be a system modal window.

[sky, 2016/04/29 00:23:18]

Fails if |transient|window_id| is a system modal window.

[mohsen, 2016/04/29 03:33:37]

I think "Fails if" is used in comments whenever the action fails gracefully such
that the client is notified of the failure to revert the client-side value.
That's not the case here as we have a DCHECK. Right?

   // This fails for any of the following reasons:
   // . |window_id| or |transient_window_id| does not identify a valid window.
   // . |transient_window_id| is an ancestor of |window_id|.
   AddTransientWindow(uint32 change_id,
                      uint32 window_id,
                      uint32 transient_window_id);
 
   // Decouples the lifetime of |transient_window_id| from its transient parent.
   // This does not change transient window's position in the window hierarchy.
   RemoveTransientWindowFromParent(uint32 change_id, uint32 transient_window_id);
 
-  // Sets |window_id| to be modal to its transient parent.
-  // This fails if |window_id| does not identify a valid window.
-  // TODO(mohsen): If |window_id| does not have a transient parent, this will
-  // have no effect. Plan is to make a window modal to system if it does not
-  // have a transient parent.
+  // Sets |window_id| to be modal. It would be modal to its transient parent if

[sky, 2016/04/29 00:23:18]

If the window has a transient parent, then the window is modal to the transient
parent. Otherwise the window is modal to the system. This releases capture if
necessary.

[mohsen, 2016/04/29 03:33:37]

Done.

+  // it has one. Otherwise, it would be modal to the whole system. It will also
+  // release capture if necessary.
+  // This fails for any of the following reasons:
+  // . |window_id| does not identify a valid window.
+  // . Client does not have a valid user id (i.e., it is an embedded app).
   SetModal(uint32 change_id, uint32 window_id);
 
   // Reorders a window in its parent, relative to |relative_window_id| according
   // to |direction|. Only the connection that created the window's parent can
   // reorder its children.
   ReorderWindow(uint32 change_id,
                 uint32 window_id,
                 uint32 relative_window_id,
                 OrderDirection direction);
 
@@ skipping 199 matching lines @@
   // See description of WindowManager for details.
   GetWindowManager(associated WindowManager& internal);
 };
 
 // Mus provides this interface as a way for clients to connect and obtain a
 // WindowTree handle with a supplied WindowTreeClient handle. The
 // WindowTreeClient has no roots, use NewTopLevelWindow() to create one.
 interface WindowTreeFactory {
   CreateWindowTree(WindowTree& tree_request, WindowTreeClient client);
 };