Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: src/objects-visiting.h

Issue 181833004: Fix memory leak caused by treating Code::next_code_link as strong in marker. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-visiting.h
diff --git a/src/objects-visiting.h b/src/objects-visiting.h
index 41e5fd6fd382b342c2506da1545de3add43f646f..6fa82704a5d53e2143747c3c8fa89e1b8b771ecb 100644
--- a/src/objects-visiting.h
+++ b/src/objects-visiting.h
@@ -151,6 +151,10 @@ class StaticVisitorBase : public AllStatic {
return Min(specialization, generic);
}
+
+ static WeakPointerMode weak_pointer_mode() {
+ return VISIT_WEAK_POINTERS;
+ }
};
@@ -420,6 +424,10 @@ class StaticMarkingVisitor : public StaticVisitorBase {
// code. This will prevent it from being flushed.
static void MarkInlinedFunctionsCode(Heap* heap, Code* code);
+ static WeakPointerMode weak_pointer_mode() {
+ return SKIP_WEAK_POINTERS;
+ }
+
protected:
INLINE(static void VisitMap(Map* map, HeapObject* object));
INLINE(static void VisitCode(Map* map, HeapObject* object));

Powered by Google App Engine
This is Rietveld 408576698