Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects-visiting.h

Issue 181833004: Fix memory leak caused by treating Code::next_code_link as strong in marker. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 INLINE(static void VisitPropertyCell(Map* map, HeapObject* object)); 407 INLINE(static void VisitPropertyCell(Map* map, HeapObject* object));
408 INLINE(static void VisitAllocationSite(Map* map, HeapObject* object)); 408 INLINE(static void VisitAllocationSite(Map* map, HeapObject* object));
409 INLINE(static void VisitCodeEntry(Heap* heap, Address entry_address)); 409 INLINE(static void VisitCodeEntry(Heap* heap, Address entry_address));
410 INLINE(static void VisitEmbeddedPointer(Heap* heap, RelocInfo* rinfo)); 410 INLINE(static void VisitEmbeddedPointer(Heap* heap, RelocInfo* rinfo));
411 INLINE(static void VisitCell(Heap* heap, RelocInfo* rinfo)); 411 INLINE(static void VisitCell(Heap* heap, RelocInfo* rinfo));
412 INLINE(static void VisitDebugTarget(Heap* heap, RelocInfo* rinfo)); 412 INLINE(static void VisitDebugTarget(Heap* heap, RelocInfo* rinfo));
413 INLINE(static void VisitCodeTarget(Heap* heap, RelocInfo* rinfo)); 413 INLINE(static void VisitCodeTarget(Heap* heap, RelocInfo* rinfo));
414 INLINE(static void VisitCodeAgeSequence(Heap* heap, RelocInfo* rinfo)); 414 INLINE(static void VisitCodeAgeSequence(Heap* heap, RelocInfo* rinfo));
415 INLINE(static void VisitExternalReference(RelocInfo* rinfo)) { } 415 INLINE(static void VisitExternalReference(RelocInfo* rinfo)) { }
416 INLINE(static void VisitRuntimeEntry(RelocInfo* rinfo)) { } 416 INLINE(static void VisitRuntimeEntry(RelocInfo* rinfo)) { }
417 // Skip the weak next code link in a code object.
418 INLINE(static void VisitNextCodeLink(Heap* heap, Object** slot)) { }
417 419
418 // TODO(mstarzinger): This should be made protected once refactoring is done. 420 // TODO(mstarzinger): This should be made protected once refactoring is done.
419 // Mark non-optimize code for functions inlined into the given optimized 421 // Mark non-optimize code for functions inlined into the given optimized
420 // code. This will prevent it from being flushed. 422 // code. This will prevent it from being flushed.
421 static void MarkInlinedFunctionsCode(Heap* heap, Code* code); 423 static void MarkInlinedFunctionsCode(Heap* heap, Code* code);
422 424
423 protected: 425 protected:
424 INLINE(static void VisitMap(Map* map, HeapObject* object)); 426 INLINE(static void VisitMap(Map* map, HeapObject* object));
425 INLINE(static void VisitCode(Map* map, HeapObject* object)); 427 INLINE(static void VisitCode(Map* map, HeapObject* object));
426 INLINE(static void VisitSharedFunctionInfo(Map* map, HeapObject* object)); 428 INLINE(static void VisitSharedFunctionInfo(Map* map, HeapObject* object));
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 479
478 480
479 template<typename StaticVisitor> 481 template<typename StaticVisitor>
480 VisitorDispatchTable<typename StaticMarkingVisitor<StaticVisitor>::Callback> 482 VisitorDispatchTable<typename StaticMarkingVisitor<StaticVisitor>::Callback>
481 StaticMarkingVisitor<StaticVisitor>::table_; 483 StaticMarkingVisitor<StaticVisitor>::table_;
482 484
483 485
484 } } // namespace v8::internal 486 } } // namespace v8::internal
485 487
486 #endif // V8_OBJECTS_VISITING_H_ 488 #endif // V8_OBJECTS_VISITING_H_
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698