Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/objects-visiting-inl.h

Issue 181833004: Fix memory leak caused by treating Code::next_code_link as strong in marker. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-visiting.h ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 880 matching lines...) Expand 10 before | Expand all | Expand 10 after
891 RelocInfo::ModeMask(RelocInfo::JS_RETURN) | 891 RelocInfo::ModeMask(RelocInfo::JS_RETURN) |
892 RelocInfo::ModeMask(RelocInfo::DEBUG_BREAK_SLOT) | 892 RelocInfo::ModeMask(RelocInfo::DEBUG_BREAK_SLOT) |
893 RelocInfo::ModeMask(RelocInfo::RUNTIME_ENTRY); 893 RelocInfo::ModeMask(RelocInfo::RUNTIME_ENTRY);
894 894
895 // There are two places where we iterate code bodies: here and the 895 // There are two places where we iterate code bodies: here and the
896 // templated CodeIterateBody (below). They should be kept in sync. 896 // templated CodeIterateBody (below). They should be kept in sync.
897 IteratePointer(v, kRelocationInfoOffset); 897 IteratePointer(v, kRelocationInfoOffset);
898 IteratePointer(v, kHandlerTableOffset); 898 IteratePointer(v, kHandlerTableOffset);
899 IteratePointer(v, kDeoptimizationDataOffset); 899 IteratePointer(v, kDeoptimizationDataOffset);
900 IteratePointer(v, kTypeFeedbackInfoOffset); 900 IteratePointer(v, kTypeFeedbackInfoOffset);
901 IterateNextCodeLink(v, kNextCodeLinkOffset);
901 IteratePointer(v, kConstantPoolOffset); 902 IteratePointer(v, kConstantPoolOffset);
902 903
903 RelocIterator it(this, mode_mask); 904 RelocIterator it(this, mode_mask);
904 Isolate* isolate = this->GetIsolate(); 905 Isolate* isolate = this->GetIsolate();
905 for (; !it.done(); it.next()) { 906 for (; !it.done(); it.next()) {
906 it.rinfo()->Visit(isolate, v); 907 it.rinfo()->Visit(isolate, v);
907 } 908 }
908 } 909 }
909 910
910 911
(...skipping 14 matching lines...) Expand all
925 reinterpret_cast<Object**>(this->address() + kRelocationInfoOffset)); 926 reinterpret_cast<Object**>(this->address() + kRelocationInfoOffset));
926 StaticVisitor::VisitPointer( 927 StaticVisitor::VisitPointer(
927 heap, 928 heap,
928 reinterpret_cast<Object**>(this->address() + kHandlerTableOffset)); 929 reinterpret_cast<Object**>(this->address() + kHandlerTableOffset));
929 StaticVisitor::VisitPointer( 930 StaticVisitor::VisitPointer(
930 heap, 931 heap,
931 reinterpret_cast<Object**>(this->address() + kDeoptimizationDataOffset)); 932 reinterpret_cast<Object**>(this->address() + kDeoptimizationDataOffset));
932 StaticVisitor::VisitPointer( 933 StaticVisitor::VisitPointer(
933 heap, 934 heap,
934 reinterpret_cast<Object**>(this->address() + kTypeFeedbackInfoOffset)); 935 reinterpret_cast<Object**>(this->address() + kTypeFeedbackInfoOffset));
936 StaticVisitor::VisitNextCodeLink(
937 heap,
938 reinterpret_cast<Object**>(this->address() + kNextCodeLinkOffset));
935 StaticVisitor::VisitPointer( 939 StaticVisitor::VisitPointer(
936 heap, 940 heap,
937 reinterpret_cast<Object**>(this->address() + kConstantPoolOffset)); 941 reinterpret_cast<Object**>(this->address() + kConstantPoolOffset));
938 942
939 943
940 RelocIterator it(this, mode_mask); 944 RelocIterator it(this, mode_mask);
941 for (; !it.done(); it.next()) { 945 for (; !it.done(); it.next()) {
942 it.rinfo()->template Visit<StaticVisitor>(heap); 946 it.rinfo()->template Visit<StaticVisitor>(heap);
943 } 947 }
944 } 948 }
945 949
946 950
947 } } // namespace v8::internal 951 } } // namespace v8::internal
948 952
949 #endif // V8_OBJECTS_VISITING_INL_H_ 953 #endif // V8_OBJECTS_VISITING_INL_H_
OLDNEW
« no previous file with comments | « src/objects-visiting.h ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698