Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: src/heap.cc

Issue 181833004: Fix memory leak caused by treating Code::next_code_link as strong in marker. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4043 matching lines...) Expand 10 before | Expand all | Expand 10 after
4054 ASSERT(!isolate_->code_range()->exists() || 4054 ASSERT(!isolate_->code_range()->exists() ||
4055 isolate_->code_range()->contains(code->address())); 4055 isolate_->code_range()->contains(code->address()));
4056 code->set_instruction_size(desc.instr_size); 4056 code->set_instruction_size(desc.instr_size);
4057 code->set_relocation_info(reloc_info); 4057 code->set_relocation_info(reloc_info);
4058 code->set_flags(flags); 4058 code->set_flags(flags);
4059 code->set_raw_kind_specific_flags1(0); 4059 code->set_raw_kind_specific_flags1(0);
4060 code->set_raw_kind_specific_flags2(0); 4060 code->set_raw_kind_specific_flags2(0);
4061 code->set_is_crankshafted(crankshafted); 4061 code->set_is_crankshafted(crankshafted);
4062 code->set_deoptimization_data(empty_fixed_array(), SKIP_WRITE_BARRIER); 4062 code->set_deoptimization_data(empty_fixed_array(), SKIP_WRITE_BARRIER);
4063 code->set_raw_type_feedback_info(undefined_value()); 4063 code->set_raw_type_feedback_info(undefined_value());
4064 code->set_next_code_link(undefined_value());
4064 code->set_handler_table(empty_fixed_array(), SKIP_WRITE_BARRIER); 4065 code->set_handler_table(empty_fixed_array(), SKIP_WRITE_BARRIER);
4065 code->set_gc_metadata(Smi::FromInt(0)); 4066 code->set_gc_metadata(Smi::FromInt(0));
4066 code->set_ic_age(global_ic_age_); 4067 code->set_ic_age(global_ic_age_);
4067 code->set_prologue_offset(prologue_offset); 4068 code->set_prologue_offset(prologue_offset);
4068 if (code->kind() == Code::OPTIMIZED_FUNCTION) { 4069 if (code->kind() == Code::OPTIMIZED_FUNCTION) {
4069 code->set_marked_for_deoptimization(false); 4070 code->set_marked_for_deoptimization(false);
4070 } 4071 }
4071 code->set_constant_pool(empty_constant_pool_array()); 4072 code->set_constant_pool(empty_constant_pool_array());
4072 4073
4073 #ifdef ENABLE_DEBUGGER_SUPPORT 4074 #ifdef ENABLE_DEBUGGER_SUPPORT
(...skipping 3603 matching lines...) Expand 10 before | Expand all | Expand 10 after
7677 static_cast<int>(object_sizes_last_time_[index])); 7678 static_cast<int>(object_sizes_last_time_[index]));
7678 CODE_AGE_LIST_COMPLETE(ADJUST_LAST_TIME_OBJECT_COUNT) 7679 CODE_AGE_LIST_COMPLETE(ADJUST_LAST_TIME_OBJECT_COUNT)
7679 #undef ADJUST_LAST_TIME_OBJECT_COUNT 7680 #undef ADJUST_LAST_TIME_OBJECT_COUNT
7680 7681
7681 OS::MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_)); 7682 OS::MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_));
7682 OS::MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_)); 7683 OS::MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_));
7683 ClearObjectStats(); 7684 ClearObjectStats();
7684 } 7685 }
7685 7686
7686 } } // namespace v8::internal 7687 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698