Fix regression in inspector breakpoints.

Handle the case for older releases (pre M51) by adding CSS fixes in compatibility script to handle the case of a border-image element that lacks the border-style.

This fixes the case of broken inspector breakpoints.

BUG=596374
Committed: https://crrev.com/a767dd5e090318016add91a610ca807cf9eef25e
Cr-Commit-Position: refs/heads/master@{#383108}

[cavalcantii1, 2016-03-22 00:24:22]

cavalcantii@chromium.org changed reviewers:
+ alancutter@chromium.org, pfeldman@chromium.org, rbyers@google.com

[cavalcantii1, 2016-03-22 00:24:22]

For review.

[Rick Byers, 2016-03-22 15:39:38]

rbyers@chromium.org changed reviewers:
+ rbyers@chromium.org
- rbyers@google.com

[Rick Byers, 2016-03-22 15:39:39]

The change LGTM

But you'll need a devtools expert to comment on the versioning implications.  Is
it OK to change blink now when we may still be served the Chrome 49 or 50
devtools front-end?  Perhaps it's not too late / risk to get this CL merged to
M50?

[cavalcantii1, 2016-03-22 16:10:54]

Rick

Thanks for reviewing.

I haven't tested this (i.e. M49-50 being debugged by M51), but as the rendering
behavior has changed on M51, it would be required to have this fix backported or
live with the artifact in the breakpoint arrow.

Assuming we decide to backport this, to whom should I talk?

[dgozman, 2016-03-22 17:52:15]

Description was changed from

==========
Fix regression in inspector breakpoints.

It turns out that there were a few places in inspector that required to
be adjusted to the current behavior of Blink
(i.e. border-style must be defined to display a border-image).

BUG=596374
==========

to

==========
Fix regression in inspector breakpoints.

It turns out that there were a few places in inspector that required to
be adjusted to the current behavior of Blink
(i.e. border-style must be defined to display a border-image).

BUG=596374
==========

[dgozman, 2016-03-22 17:52:15]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[Rick Byers, 2016-03-23 02:14:18]

rbyers@chromium.org changed reviewers:
- pfeldman@chromium.org

[Rick Byers, 2016-03-23 02:16:17]

For the record, we talked with dgozman offline who said we need to update the
back-compat script in devtools.js (as part of this patch) to make sure chrome
still works with older devtools front-ends deployed in the wild.

[lushnikov, 2016-03-23 22:10:49]

lushnikov@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2016-03-23 22:10:49]

https://codereview.chromium.org/1818263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css
(right):

https://codereview.chromium.org/1818263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css:102:
border-style: solid;
no need to change this file altogether - this has already been done at
crrev.com/1822653004

[cavalcantii1, 2016-03-23 22:19:10]

@lushnikov

I guess you beat me at fixing it.
:-)

I'm curious that it required to set border-style only on 1 point (is the
property inherited in the other points?).

[cavalcantii1, 2016-03-23 22:20:04]

That being said, the spec requires to *always* have a border style defined if
you have border-image set in an element.

I feel it makes it explicit by setting border-style whenever there is a case of
use of border-image.

What you guys think?

[cavalcantii1, 2016-03-23 22:28:51]

Description was changed from

==========
Fix regression in inspector breakpoints.

It turns out that there were a few places in inspector that required to
be adjusted to the current behavior of Blink
(i.e. border-style must be defined to display a border-image).

BUG=596374
==========

to

==========
Fix regression in inspector breakpoints.

It turns out that there were a few places in inspector that required to be
adjusted to the current behavior of Blink
(i.e. border-style must be defined to display a border-image).

To handle the case of older releases (pre M51), we add the CSS fixes in
compatibility script.

BUG=596374
==========

[dgozman, 2016-03-24 01:05:57]

On 2016/03/23 22:20:04, cavalcantii1 wrote:
> That being said, the spec requires to *always* have a border style defined if
> you have border-image set in an element.
> 
> I feel it makes it explicit by setting border-style whenever there is a case
of
> use of border-image.
> 
> What you guys think?

I think extra border-style will not hurt anybody. Just rebase on top of
crrev.com/1822653004 and we can land this.

[cavalcantii1, 2016-03-24 02:12:27]

It is already rebased.
:-)

[dgozman, 2016-03-24 03:08:08]

On 2016/03/24 02:12:27, cavalcantii1 wrote:
> It is already rebased.
> :-)

Sorry, but this line seems to be committed and is missing from your patch:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[cavalcantii1, 2016-03-24 03:16:12]

Indeed, maybe it was squashed by git? This is the hash I rebased my patch on
top:
https://gist.github.com/Adenilson/ec0ec5696a5261208c88

[cavalcantii1, 2016-03-24 03:17:52]

Oops, my bad: I did rebase, but forgot to upload.

[cavalcantii1, 2016-03-24 03:24:07]

Now it should be ok (famous last words...).

[lushnikov, 2016-03-24 04:05:58]

@cavalcantii1: yes, there's no need for the additional border-style properties -
this is basically the same selector with slightly higher specificity.

https://codereview.chromium.org/1818263002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css
(right):

https://codereview.chromium.org/1818263002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css:92:
border-style: solid;
no need for this - it's basically slightly more specific selector then the one
defined at line 74.

https://codereview.chromium.org/1818263002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css:98:
border-style: solid;
ditto

https://codereview.chromium.org/1818263002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css:102:
border-style: solid;
ditto

[cavalcantii1, 2016-03-24 04:40:41]

Description was changed from

==========
Fix regression in inspector breakpoints.

It turns out that there were a few places in inspector that required to be
adjusted to the current behavior of Blink
(i.e. border-style must be defined to display a border-image).

To handle the case of older releases (pre M51), we add the CSS fixes in
compatibility script.

BUG=596374
==========

to

==========
Handle the case for older releases (pre M51) by adding CSS fixes in
compatibility script to handle the case of a border-image element that lacks the
border-style.

This fixes the case of broken inspector breakpoints.
==========

[cavalcantii1, 2016-03-24 04:43:37]

Description was changed from

==========
Handle the case for older releases (pre M51) by adding CSS fixes in
compatibility script to handle the case of a border-image element that lacks the
border-style.

This fixes the case of broken inspector breakpoints.
==========

to

==========
Handle the case for older releases (pre M51) by adding CSS fixes in
compatibility script to handle the case of a border-image element that lacks the
border-style.

This fixes the case of broken inspector breakpoints.

BUG=596374
==========

[dgozman, 2016-03-24 17:12:32]

lgtm. Thank you for the fix!

[lushnikov, 2016-03-24 17:13:09]

@cavalcantii1 thanks man! lgtm!

[cavalcantii1, 2016-03-24 17:22:40]

The CQ bit was checked by cavalcantii@chromium.org

[cavalcantii1, 2016-03-24 17:22:41]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1818263002/#ps80001
(title: "Only touches the compatibility script")

[commit-bot: I haz the power, 2016-03-24 17:22:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818263002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818263002/80001

[commit-bot: I haz the power, 2016-03-24 18:53:58]

Description was changed from

==========
Handle the case for older releases (pre M51) by adding CSS fixes in
compatibility script to handle the case of a border-image element that lacks the
border-style.

This fixes the case of broken inspector breakpoints.

BUG=596374
==========

to

==========
Handle the case for older releases (pre M51) by adding CSS fixes in
compatibility script to handle the case of a border-image element that lacks the
border-style.

This fixes the case of broken inspector breakpoints.

BUG=596374
==========

[commit-bot: I haz the power, 2016-03-24 18:53:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-24 18:57:11]

Description was changed from

==========
Handle the case for older releases (pre M51) by adding CSS fixes in
compatibility script to handle the case of a border-image element that lacks the
border-style.

This fixes the case of broken inspector breakpoints.

BUG=596374
==========

to

==========
Handle the case for older releases (pre M51) by adding CSS fixes in
compatibility script to handle the case of a border-image element that lacks the
border-style.

This fixes the case of broken inspector breakpoints.

BUG=596374

Committed: https://crrev.com/a767dd5e090318016add91a610ca807cf9eef25e
Cr-Commit-Position: refs/heads/master@{#383108}
==========

[commit-bot: I haz the power, 2016-03-24 18:57:13]

Patchset 5 (id:??) landed as
https://crrev.com/a767dd5e090318016add91a610ca807cf9eef25e
Cr-Commit-Position: refs/heads/master@{#383108}