Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 1818253003: blimp: Disable custom web fonts on the engine (Closed)

Created:
4 years, 9 months ago by Khushal
Modified:
4 years, 9 months ago
Reviewers:
haibinlu, maniscalco
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blimp: Disable custom web fonts on the engine BUG=593180 Committed: https://crrev.com/a612bb87ff57998506b7de1bf2a1c6b885cadd6a Cr-Commit-Position: refs/heads/master@{#382721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M blimp/docs/running.md View 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/engine/start_engine.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Khushal
4 years, 9 months ago (2016-03-22 06:42:37 UTC) #2
maniscalco
LGTM. I assume yes, but can you confirm you tested this change by running the ...
4 years, 9 months ago (2016-03-22 15:21:52 UTC) #3
haibinlu
lgtm
4 years, 9 months ago (2016-03-22 17:17:26 UTC) #4
Khushal
On 2016/03/22 15:21:52, maniscalco wrote: > LGTM. I assume yes, but can you confirm you ...
4 years, 9 months ago (2016-03-22 21:20:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818253003/1
4 years, 9 months ago (2016-03-22 21:21:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 23:02:46 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 23:03:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a612bb87ff57998506b7de1bf2a1c6b885cadd6a
Cr-Commit-Position: refs/heads/master@{#382721}

Powered by Google App Engine
This is Rietveld 408576698