webkit/child/webkitplatformsupport_impl.cc - Issue 181823006: Add DCHECK for shared_timer_suspended_ which shouldn't be negative

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/child/webkitplatformsupport_impl.cc

Issue 181823006: Add DCHECK for shared_timer_suspended_ which shouldn't be negative (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Take review comment into consideration Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/child/webkitplatformsupport_impl.cc

diff --git a/webkit/child/webkitplatformsupport_impl.cc b/webkit/child/webkitplatformsupport_impl.cc

index c958c38c039db5aa9268de4a85f45fec2309a666..ceb9b8068680e7e4c35a7658e67dcb80afa13739 100644

--- a/webkit/child/webkitplatformsupport_impl.cc

+++ b/webkit/child/webkitplatformsupport_impl.cc

@@ -905,6 +905,8 @@ void WebKitPlatformSupportImpl::SuspendSharedTimer() {

}

void WebKitPlatformSupportImpl::ResumeSharedTimer() {

+ DCHECK(shared_timer_suspended_ > 0);

jamesr 2014/03/07 05:46:26 nit: DCHECK_GT() gives a slightly better error mes

// The shared timer may have fired or been adjusted while we were suspended.

if (--shared_timer_suspended_ == 0 &&

(!shared_timer_.IsRunning() ||

« no previous file with comments | « content/browser/android/content_view_statics.cc ('k') | no next file » | no next file with comments »