Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1818203002: Fix Cast Streaming regression caused by enabling H264 HW encoder on Mac. (Closed)

Created:
4 years, 9 months ago by miu
Modified:
4 years, 9 months ago
Reviewers:
emircan
CC:
avayvod+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jasonroberts+watch_google.com, miu+watch_chromium.org, xjz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Cast Streaming regression caused by enabling H264 HW encoder on Mac. A recent commit (3956fa1cac34dd5682c271d77463accdd7191102) turned on detection and use of the H264 hardware encoder for Mac desktop. This caused breakage in the form of a "black screen." This change reverts to the prior behavior of always using the software VP8 encoder on Macs. BUG=596674 Committed: https://crrev.com/5f6bf2ab1d3619432d6d0a5021008d500b7e1c37 Cr-Commit-Position: refs/heads/master@{#382432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/renderer/media/cast_rtp_stream.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/end_to_end_sender.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
miu
4 years, 9 months ago (2016-03-21 21:57:31 UTC) #2
emircan
lgtm
4 years, 9 months ago (2016-03-21 22:01:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818203002/1
4 years, 9 months ago (2016-03-21 22:04:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 23:20:14 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 23:23:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f6bf2ab1d3619432d6d0a5021008d500b7e1c37
Cr-Commit-Position: refs/heads/master@{#382432}

Powered by Google App Engine
This is Rietveld 408576698