base/message_loop/message_loop.cc - Issue 18181011: Make a fairer combined message loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop/message_loop.cc

Issue 18181011: Make a fairer combined message loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated to ask the pump if it needs to be notified for each work item added Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/message_loop/message_loop.cc

diff --git a/base/message_loop/message_loop.cc b/base/message_loop/message_loop.cc

index 9e33a426eb9f1241be625c25aee1a1585898c6fc..60f0fb89a9107cdec9d39ad2d9236c3b958a697e 100644

--- a/base/message_loop/message_loop.cc

+++ b/base/message_loop/message_loop.cc

@@ -624,7 +624,9 @@ bool MessageLoop::AddToIncomingQueue(PendingTask* pending_task,

bool was_empty = incoming_queue_.empty();

incoming_queue_.push(*pending_task);

pending_task->task.Reset();

- if (!was_empty)

+ // The Android UI message loop needs to get notified each time

+ // a task is added to the incoming queue

+ if (!was_empty && !pump_->NeedsScheduleWorkPerTask())

return true; // Someone else should have started the sub-pump.

pump = pump_;