Make a fairer combined message loop

base/message_loop/message_loop.cc

Index: base/message_loop/message_loop.cc
diff --git a/base/message_loop/message_loop.cc b/base/message_loop/message_loop.cc
index 4e0c5f6801e9e15d36a5e7d220d0b956ff91f7a9..0d11d26ae0b86ec7dd6395bc13519a49f7c64b06 100644
--- a/base/message_loop/message_loop.cc
+++ b/base/message_loop/message_loop.cc
@@ -624,7 +624,7 @@ bool MessageLoop::AddToIncomingQueue(PendingTask* pending_task,
     bool was_empty = incoming_queue_.empty();
     incoming_queue_.push(*pending_task);
     pending_task->task.Reset();
-    if (!was_empty)
+    if (!was_empty && !IsType(TYPE_UI))

[klobag.chromium, 2013/06/28 20:57:13]

Do you need this to get ScheduleWork() called? Should it inside #if ANDROID?

[Kristian Monsen, 2013/06/28 21:04:41]

Yes, this is to avoid early out and always get ScheduleWork called on the UI
message loop on Android. If it has a performance impact on other platforms we
can add an #ifdef ANDROID, but want to avoid that if possible.

[joth, 2013/07/01 19:28:54]

Might be cleaner to delegate this to the pump:
if (!was_empty && !pump->NeedsScheduleWorkPerTask()) ...


also, It would be easy for someone to regress this and break android. Can we
think of anyway to add a test for this?

[Kristian Monsen, 2013/07/02 21:32:27]

Delegated to the pump.

       return true;  // Someone else should have started the sub-pump.
 
     pump = pump_;