 Chromium Code Reviews
 Chromium Code Reviews Issue 18181010:
  Simplify media controls CSS  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 18181010:
  Simplify media controls CSS  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/css/mediaControlsChromiumAndroid.css | 
| diff --git a/Source/core/css/mediaControlsChromiumAndroid.css b/Source/core/css/mediaControlsChromiumAndroid.css | 
| index 93623c3774fe1db6919b5c9afa27cd947d6b3f89..7ff061a06943c766a10de1bc608471a4d295e4db 100644 | 
| --- a/Source/core/css/mediaControlsChromiumAndroid.css | 
| +++ b/Source/core/css/mediaControlsChromiumAndroid.css | 
| @@ -22,57 +22,19 @@ | 
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 
| */ | 
| -/* Media controls for Chromium on Android*/ | 
| - | 
| -body:-webkit-full-page-media { | 
| - background-color: rgb(0, 0, 0); | 
| -} | 
| +/* Media controls for Chromium on Android */ | 
| audio { | 
| - width: 300px; | 
| - height: 35px; | 
| -} | 
| - | 
| -audio:-webkit-full-page-media, video:-webkit-full-page-media { | 
| - max-height: 100%; | 
| - max-width: 100%; | 
| -} | 
| - | 
| -audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel { | 
| - display: -webkit-flex; | 
| - -webkit-flex-direction: row; | 
| - -webkit-align-items: center; | 
| - -webkit-justify-content: center; | 
| - bottom: auto; | 
| height: 35px; | 
| - background-color: rgba(20, 20, 20, 0.8); | 
| -} | 
| - | 
| -audio:-webkit-full-page-media::-webkit-media-controls-panel, | 
| -video:-webkit-full-page-media::-webkit-media-controls-panel { | 
| - bottom: 0px; | 
| -} | 
| - | 
| -::-webkit-media-controls { | 
| - display: -webkit-flex; | 
| - -webkit-flex-direction: column; | 
| - -webkit-justify-content: flex-end; | 
| - -webkit-align-items: center; | 
| } | 
| audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure { | 
| - width: 100%; | 
| - max-width: 800px; | 
| height: 35px; | 
| - bottom: 0; | 
| - text-indent: 0; | 
| - padding: 0; | 
| - box-sizing: border-box; | 
| + -webkit-flex-shrink: initial; | 
| } | 
| video::-webkit-media-controls-enclosure { | 
| - padding: 0px 5px 5px 5px; | 
| - height: 35px; | 
| + -webkit-flex-shrink: initial; | 
| } | 
| audio::-webkit-media-controls-overlay-enclosure { | 
| @@ -93,21 +55,14 @@ video::-webkit-media-controls-overlay-enclosure { | 
| overflow: hidden; | 
| } | 
| -audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button { | 
| - display: none; | 
| +audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel { | 
| + -webkit-justify-content: center; | 
| + height: 35px; | 
| + border-radius: initial; | 
| } | 
| -audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button { | 
| - -webkit-appearance: media-play-button; | 
| - display: inline; | 
| - border: none; | 
| - box-sizing: border-box; | 
| - width: 35px; | 
| - height: 35px; | 
| - line-height: 35px; | 
| - margin-left: 9px; | 
| - margin-right: 9px; | 
| - padding: 0; | 
| +audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button { | 
| + display: none; | 
| } | 
| video::-webkit-media-controls-overlay-play-button { | 
| @@ -126,96 +81,48 @@ video::-webkit-media-controls-overlay-play-button { | 
| padding: 0; | 
| } | 
| +audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button { | 
| + display: inline; | 
| + -webkit-flex: initial; | 
| + width: 35px; | 
| + height: 35px; | 
| + line-height: 35px; | 
| +} | 
| + | 
| audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display, | 
| audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display { | 
| - -webkit-appearance: media-current-time-display; | 
| - -webkit-user-select: none; | 
| + -webkit-flex: initial; | 
| display: block; | 
| - border: none; | 
| - cursor: default; | 
| height: 35px; | 
| - margin: 0 9px 0 0; | 
| - padding: 0; | 
| line-height: 35px; | 
| - font-family: Arial, Helvetica, sans-serif; | 
| font-size: 18px; | 
| - font-weight: bold; | 
| - color: white; | 
| - | 
| - letter-spacing: normal; | 
| - word-spacing: normal; | 
| - text-transform: none; | 
| - text-indent: 0; | 
| - text-shadow: none; | 
| - text-decoration: none; | 
| + font-style: initial; | 
| 
qinmin
2013/07/02 03:15:14
there are lots of initial value in the new css, wh
 
philipj_slow
2013/07/02 08:16:22
I think that all instances of *: initial can be re
 | 
| } | 
| audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline { | 
| - -webkit-appearance: media-slider; | 
| - display: -webkit-flex; | 
| -webkit-flex: 1 1; | 
| 
acolwell GONE FROM CHROMIUM
2013/07/03 16:21:55
Isn't this equivalent to 1 1 auto? I think this ca
 
philipj_slow
2013/07/04 08:40:26
It's actually equivlant to 1 1 0, tested both with
 | 
| - height: 8px; | 
| - margin: 0 15px 0 0; | 
| - padding: 0; | 
| - background-color: transparent; | 
| - min-width: 25px; | 
| } | 
| - | 
| -video::-webkit-media-controls-fullscreen-button { | 
| - -webkit-appearance: media-enter-fullscreen-button; | 
| - display: -webkit-flex; | 
| - border: none; | 
| - box-sizing: border-box; | 
| - width: 35px; | 
| - height: 35px; | 
| - line-height: 35px; | 
| - margin-left: -5px; | 
| - margin-right: 9px; | 
| - padding: 0; | 
| +audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider { | 
| + display: none; | 
| } | 
| -audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button { | 
| - -webkit-appearance: media-toggle-closed-captions-button; | 
| - display: -webkit-flex; | 
| - border: none; | 
| - box-sizing: border-box; | 
| +video::-webkit-media-controls-fullscreen-button { | 
| + -webkit-flex: initial; | 
| width: 35px; | 
| height: 35px; | 
| line-height: 35px; | 
| - margin-left: -5px; | 
| - margin-right: 9px; | 
| - padding: 0; | 
| -} | 
| - | 
| -input[type="range"]::-webkit-media-slider-container { | 
| - display: -webkit-flex; | 
| - -webkit-align-items: center; | 
| - -webkit-flex-direction: row; | 
| - box-sizing: border-box; | 
| - height: 100%; | 
| - width: 100%; | 
| - border: 1px solid rgba(230, 230, 230, 0.35); | 
| - border-radius: 4px; | 
| - background-color: transparent; | 
| -} | 
| - | 
| -/* The negative right margin causes the track to overflow its container. */ | 
| -input[type="range"]::-webkit-media-slider-container > div { | 
| - margin-right: -14px; | 
| -} | 
| - | 
| -input[type="range"]::-webkit-media-slider-thumb { | 
| - margin-left: -7px; | 
| - margin-right: -7px; | 
| } | 
| audio::-webkit-media-controls-fullscreen-button { | 
| display: none; | 
| } | 
| -audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider { | 
| - display: none; | 
| +audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button { | 
| + -webkit-flex: initial; | 
| + width: 35px; | 
| + height: 35px; | 
| + line-height: 35px; | 
| } |