Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 18181006: Introduce a notion of "v8_code" in gyp config files. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Introduce a notion of "v8_code" in gyp config files. This allows for compiling third-party code (such as ICU) with less strict flags. BUG=v8:2745 R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15389

Patch Set 1 #

Total comments: 4

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M build/standalone.gypi View 1 4 chunks +38 lines, -0 lines 0 comments Download
M preparser/preparser.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M samples/samples.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/d8.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M src/third_party/vtune/v8vtune.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-06-28 09:19:21 UTC) #1
Jakob Kummerow
LGTM if you merge the 'conditions' sections. Also, please verify that with this change V8 ...
7 years, 5 months ago (2013-06-28 09:48:13 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/18181006/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/18181006/diff/1/build/standalone.gypi#newcode33 build/standalone.gypi:33: 'clang%': 0, On 2013/06/28 09:48:14, Jakob wrote: > What's ...
7 years, 5 months ago (2013-06-28 10:09:15 UTC) #3
jochen (gone - plz use gerrit)
I made sure that v8 in chrome compiles just fine (as expected). I also put ...
7 years, 5 months ago (2013-06-28 10:12:51 UTC) #4
Jakob Kummerow
7 years, 5 months ago (2013-06-28 15:22:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698