Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1818093002: Minor fixes to avoid NVPR in Vulkan and provide good GrVkGpu teardown. (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/gpu/GrContextFactory.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jvanverth1
4 years, 9 months ago (2016-03-21 17:32:12 UTC) #3
egdaniel
lgtm
4 years, 9 months ago (2016-03-21 17:46:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818093002/20001
4 years, 9 months ago (2016-03-21 18:30:15 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:46:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ddf9835e9cdf512b1d5172d014f00ceb6dacd039

Powered by Google App Engine
This is Rietveld 408576698