Create symlink to adb in home dir right before device setup.

Create symlink to adb in home dir right before device setup.

Depends on https://codereview.chromium.org/1811933007/

BUG=565452
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299412

[bpastene, 2016-03-21 17:36:44]

bpastene@chromium.org changed reviewers:
+ jbudorick@chromium.org

[bpastene, 2016-03-21 17:36:46]

ptal

[jbudorick, 2016-03-21 18:00:21]

lgtm w/ nit

https://codereview.chromium.org/1818083003/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/1818083003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:272: infra_step=True,
nit: get rid of the comma here and bring the closing paren up

[bpastene, 2016-03-21 18:08:01]

Committing (and ready to revert if the world explodes again)

https://codereview.chromium.org/1818083003/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/1818083003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:272: infra_step=True,
On 2016/03/21 18:00:20, jbudorick wrote:
> nit: get rid of the comma here and bring the closing paren up

Done.

[bpastene, 2016-03-21 18:09:02]

The CQ bit was checked by bpastene@chromium.org

[bpastene, 2016-03-21 18:09:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1818083003/#ps40001
(title: "Nit")

[commit-bot: I haz the power, 2016-03-21 18:09:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818083003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818083003/40001

[commit-bot: I haz the power, 2016-03-21 18:15:50]

Description was changed from

==========
Create symlink to adb in home dir right before device setup.

Depends on https://codereview.chromium.org/1811933007/

BUG=565452
==========

to

==========
Create symlink to adb in home dir right before device setup.

Depends on https://codereview.chromium.org/1811933007/

BUG=565452

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299412
==========

[commit-bot: I haz the power, 2016-03-21 18:15:52]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299412

[kjellander_chromium, 2016-03-22 10:12:58]

On 2016/03/21 18:15:52, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=299412

This fails on our WebRTC Android bots. Example:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%...

I have verified the source
(/b/build/slave/android/build/src/third_party/android_tools/sdk/platform-tools/adb)
exists on the machine so my guess is that it fails because
/b/build/slave/android/build/src/third_party/android_tools
is actually a symlink it self to
/b/build/slave/android/build/src/chromium/src/third_party/android_tools
(it's the way WebRTC reuses the Chromium toolchain).

Creating a symlink manually in the shell works with:
ln -s
/b/build/slave/android/build/src/third_party/android_tools/sdk/platform-tools/adb
~/adb
so there must be something that confuses the build/symlink.py script.

Maybe you can just add support for this use case to build/symlink.py? The bots
turn purple on this step, but everything else keeps working (but I'm afraid that
might change in case you're planning on depending on this link).

[kjellander_chromium, 2016-03-22 10:21:24]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1821973002/ by kjellander@chromium.org.

The reason for reverting is: Fails on WebRTC bots, example:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%...

See previous CL message for details. Since those bots turning purple blocks our
CQ, I'm reverting this..

[bpastene, 2016-03-22 16:32:07]

On 2016/03/22 10:12:58, kjellander (chromium) wrote:
> This fails on our WebRTC Android bots. Example:
>
https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%...
>
> Maybe you can just add support for this use case to build/symlink.py? The bots
> turn purple on this step, but everything else keeps working (but I'm afraid
that
> might change in case you're planning on depending on this link).

Weird, I'll look into what's causing this and see if I can't fix it. Sorry for
the disruption.