Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1818063002: Disable ES6 tail call elimination for native functions. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable ES6 tail call elimination for native functions. We don't want them to disappear from the stack traces. BUG=v8:4698 LOG=N Committed: https://crrev.com/35a14c75e397302655d7b3fbe648f9490ae84b7d Cr-Commit-Position: refs/heads/master@{#34957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/parsing/parser.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/parsing/parser-base.h View 3 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/function-caller.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strict-mode.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818063002/1
4 years, 9 months ago (2016-03-21 15:21:57 UTC) #2
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-21 15:22:10 UTC) #4
rossberg
lgtm
4 years, 9 months ago (2016-03-21 15:25:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818063002/1
4 years, 9 months ago (2016-03-21 15:55:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 17:43:55 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 17:45:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35a14c75e397302655d7b3fbe648f9490ae84b7d
Cr-Commit-Position: refs/heads/master@{#34957}

Powered by Google App Engine
This is Rietveld 408576698