Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issue 1818043004: Fix JSInliningHeuristic::CandidateCompare predicate. (Closed)

Created:
4 years, 9 months ago by ulan
Modified:
4 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix JSInliningHeuristic::CandidateCompare predicate. STL requires comparison to be a strict weak ordering. In particular the predicate should be antisymmetric: f(x, y) implies !f(y, x). BUG=v8:4848 LOG=NO Committed: https://crrev.com/5ff7901e24c2c6029114567de5a08ed0f1494c81 Cr-Commit-Position: refs/heads/master@{#34960}

Patch Set 1 #

Patch Set 2 : Correct fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/js-inlining-heuristic.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
ulan
PTAL
4 years, 9 months ago (2016-03-21 17:33:03 UTC) #3
Michael Starzinger
LGTM. Thanks!
4 years, 9 months ago (2016-03-21 17:46:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818043004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818043004/20001
4 years, 9 months ago (2016-03-21 17:46:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 18:26:31 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:26:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ff7901e24c2c6029114567de5a08ed0f1494c81
Cr-Commit-Position: refs/heads/master@{#34960}

Powered by Google App Engine
This is Rietveld 408576698