Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1818043003: unified PNG encoding between SkDrawCommand and skiaserve (Closed)

Created:
4 years, 9 months ago by ethannicholas
Modified:
4 years, 9 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -58 lines) Patch
M gyp/debugger.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/debugger/SkDrawCommand.h View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 chunk +49 lines, -20 lines 0 comments Download
M tools/skiaserve/Request.cpp View 2 chunks +2 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ethannicholas
This should fix the image encoding error you were seeing.
4 years, 9 months ago (2016-03-21 16:58:24 UTC) #3
jcgregorio
lgtm
4 years, 9 months ago (2016-03-21 17:03:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818043003/1
4 years, 9 months ago (2016-03-21 17:04:27 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 17:19:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f67531f713467c49e7d8d2e3180357e8cf868bdc

Powered by Google App Engine
This is Rietveld 408576698